diff options
author | Mathieu Chartier <mathieuc@google.com> | 2014-03-20 15:40:37 -0700 |
---|---|---|
committer | Mathieu Chartier <mathieuc@google.com> | 2014-03-20 15:40:37 -0700 |
commit | 36bf21665b43adc2485167cbb3a044dbdf4931ee (patch) | |
tree | e5831941fc6b6fc80da0ea35110a5c5bfa1c1d56 | |
parent | afb21d16bd2267f7f34e63a5b5105f7572455d22 (diff) | |
download | art-36bf21665b43adc2485167cbb3a044dbdf4931ee.zip art-36bf21665b43adc2485167cbb3a044dbdf4931ee.tar.gz art-36bf21665b43adc2485167cbb3a044dbdf4931ee.tar.bz2 |
Add Heap::RunningOnValgrind and call it from the spaces.
Makes it easier to disable valgrind support.
Change-Id: I1bde792f1b76a2dd968fa03c6142e92fcc3670b0
-rw-r--r-- | runtime/gc/heap.h | 3 | ||||
-rw-r--r-- | runtime/gc/space/dlmalloc_space.cc | 2 | ||||
-rw-r--r-- | runtime/gc/space/rosalloc_space.cc | 2 |
3 files changed, 5 insertions, 2 deletions
diff --git a/runtime/gc/heap.h b/runtime/gc/heap.h index eb53ba9..f650005 100644 --- a/runtime/gc/heap.h +++ b/runtime/gc/heap.h @@ -553,6 +553,9 @@ class Heap { void RemoveRememberedSet(space::Space* space); bool IsCompilingBoot() const; + bool RunningOnValgrind() const { + return running_on_valgrind_; + } bool HasImageSpace() const; private: diff --git a/runtime/gc/space/dlmalloc_space.cc b/runtime/gc/space/dlmalloc_space.cc index 0597422..30c2edb 100644 --- a/runtime/gc/space/dlmalloc_space.cc +++ b/runtime/gc/space/dlmalloc_space.cc @@ -60,7 +60,7 @@ DlMallocSpace* DlMallocSpace::CreateFromMemMap(MemMap* mem_map, const std::strin // Everything is set so record in immutable structure and leave byte* begin = mem_map->Begin(); - if (RUNNING_ON_VALGRIND > 0) { + if (Runtime::Current()->GetHeap()->RunningOnValgrind()) { return new ValgrindMallocSpace<DlMallocSpace, void*>( name, mem_map, mspace, begin, end, begin + capacity, growth_limit, initial_size); } else { diff --git a/runtime/gc/space/rosalloc_space.cc b/runtime/gc/space/rosalloc_space.cc index 80c7ca7..fbb2afe 100644 --- a/runtime/gc/space/rosalloc_space.cc +++ b/runtime/gc/space/rosalloc_space.cc @@ -65,7 +65,7 @@ RosAllocSpace* RosAllocSpace::CreateFromMemMap(MemMap* mem_map, const std::strin byte* begin = mem_map->Begin(); // TODO: Fix RosAllocSpace to support valgrind. There is currently some issues with // AllocationSize caused by redzones. b/12944686 - if (false && RUNNING_ON_VALGRIND > 0) { + if (false && Runtime::Current()->GetHeap()->RunningOnValgrind()) { return new ValgrindMallocSpace<RosAllocSpace, allocator::RosAlloc*>( name, mem_map, rosalloc, begin, end, begin + capacity, growth_limit, initial_size); } else { |