diff options
| author | Vladimir Marko <vmarko@google.com> | 2015-04-25 17:00:45 +0100 |
|---|---|---|
| committer | Vladimir Marko <vmarko@google.com> | 2015-04-27 15:41:04 +0100 |
| commit | f725550c8df90f8ec07395d9be5177a4be591c12 (patch) | |
| tree | bfecc5637c57f4593e0bd73c11ad7a8887f4f988 /compiler/dex/bb_optimizations.h | |
| parent | a0ee862288b702468f8c2b6d0ad0f1c61be0b483 (diff) | |
| download | art-f725550c8df90f8ec07395d9be5177a4be591c12.zip art-f725550c8df90f8ec07395d9be5177a4be591c12.tar.gz art-f725550c8df90f8ec07395d9be5177a4be591c12.tar.bz2 | |
Quick: Avoid unnecessary GVN work in release builds.
In GVN's post-processing phase, compare LVNs only in debug
builds as they should be equal anyway.
Remove the Gate() from GVN cleanup pass and remove the
DCHECK() from MIRGraph::GlobalValueNumberingCleanup()
to make it a no-op if the GVN didn't run.
Bug: 16398693
Change-Id: Ia4f1e7e3ecf12d0305966c86e0e7dbae61dab0b7
Diffstat (limited to 'compiler/dex/bb_optimizations.h')
| -rw-r--r-- | compiler/dex/bb_optimizations.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/compiler/dex/bb_optimizations.h b/compiler/dex/bb_optimizations.h index b948afd..eb87c29 100644 --- a/compiler/dex/bb_optimizations.h +++ b/compiler/dex/bb_optimizations.h @@ -284,9 +284,6 @@ class GlobalValueNumberingCleanupPass : public PassME { : PassME("GVNCleanup", kNoNodes, "") { } - // Depends on GlobalValueNumbering, so implemented in cc file. - bool Gate(const PassDataHolder* data) const OVERRIDE; - void Start(PassDataHolder* data) const OVERRIDE { DCHECK(data != nullptr); CompilationUnit* c_unit = down_cast<const PassMEDataHolder*>(data)->c_unit; |