summaryrefslogtreecommitdiffstats
path: root/compiler/optimizing/nodes.h
diff options
context:
space:
mode:
authorNicolas Geoffray <ngeoffray@google.com>2015-04-26 16:43:18 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2015-04-26 16:43:19 +0000
commitadf15974e0a0a2b0e6dc311ff5701b87ca15964a (patch)
tree65cc0394a15ea82df9ccb680b1ec6b3be72a1a87 /compiler/optimizing/nodes.h
parent5ff903a589af282f516bbcf6844ff2656ce76b02 (diff)
parent067cae2c86627d2edcf01b918ee601774bc76aeb (diff)
downloadart-adf15974e0a0a2b0e6dc311ff5701b87ca15964a.zip
art-adf15974e0a0a2b0e6dc311ff5701b87ca15964a.tar.gz
art-adf15974e0a0a2b0e6dc311ff5701b87ca15964a.tar.bz2
Merge "Revert "[optimizing] Replace FP divide by power of 2""
Diffstat (limited to 'compiler/optimizing/nodes.h')
-rw-r--r--compiler/optimizing/nodes.h14
1 files changed, 7 insertions, 7 deletions
diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h
index 5ce0b8e..938d6fc 100644
--- a/compiler/optimizing/nodes.h
+++ b/compiler/optimizing/nodes.h
@@ -242,7 +242,7 @@ class HGraph : public ArenaObject<kArenaAllocMisc> {
// Returns a constant of the given type and value. If it does not exist
// already, it is created and inserted into the graph. Only integral types
- // are currently cached.
+ // are currently supported.
HConstant* GetConstant(Primitive::Type type, int64_t value);
HNullConstant* GetNullConstant();
HIntConstant* GetIntConstant(int32_t value) {
@@ -251,8 +251,6 @@ class HGraph : public ArenaObject<kArenaAllocMisc> {
HLongConstant* GetLongConstant(int64_t value) {
return CreateConstant(value, &cached_long_constants_);
}
- HFloatConstant* GetFloatConstant(float value);
- HDoubleConstant* GetDoubleConstant(double value);
HBasicBlock* FindCommonDominator(HBasicBlock* first, HBasicBlock* second) const;
@@ -2039,9 +2037,10 @@ class HFloatConstant : public HConstant {
const float value_;
- // Only the SsaBuilder and HGraph can create floating-point constants.
+ // Only the SsaBuilder can currently create floating-point constants. If we
+ // ever need to create them later in the pipeline, we will have to handle them
+ // the same way as integral constants.
friend class SsaBuilder;
- friend class HGraph;
DISALLOW_COPY_AND_ASSIGN(HFloatConstant);
};
@@ -2075,9 +2074,10 @@ class HDoubleConstant : public HConstant {
const double value_;
- // Only the SsaBuilder and HGraph can create floating-point constants.
+ // Only the SsaBuilder can currently create floating-point constants. If we
+ // ever need to create them later in the pipeline, we will have to handle them
+ // the same way as integral constants.
friend class SsaBuilder;
- friend class HGraph;
DISALLOW_COPY_AND_ASSIGN(HDoubleConstant);
};