diff options
| author | Andreas Gampe <agampe@google.com> | 2014-08-06 15:31:06 -0700 |
|---|---|---|
| committer | Andreas Gampe <agampe@google.com> | 2014-08-08 10:48:44 -0700 |
| commit | 54e15de4a3ea869488d50694fa01138901e70c4e (patch) | |
| tree | 9bb3bc73aaac2fb544e1fdbe5b6eb53cc7f5aaf7 /compiler/utils | |
| parent | 147594f8815ed0982d7e5676dc8b6fed5a0ba9e6 (diff) | |
| download | art-54e15de4a3ea869488d50694fa01138901e70c4e.zip art-54e15de4a3ea869488d50694fa01138901e70c4e.tar.gz art-54e15de4a3ea869488d50694fa01138901e70c4e.tar.bz2 | |
ART: Make assembler_test less chatty
Do not save temporaries in case we use a different encoding than
the host assembler.
Bug: 16505797
Change-Id: Iaa9edfe8bc84d7f809f5b403de902b92b0998431
Diffstat (limited to 'compiler/utils')
| -rw-r--r-- | compiler/utils/assembler_test.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/compiler/utils/assembler_test.h b/compiler/utils/assembler_test.h index 05ac70e..3742913 100644 --- a/compiler/utils/assembler_test.h +++ b/compiler/utils/assembler_test.h @@ -361,12 +361,15 @@ class AssemblerTest : public testing::Test { } else { if (DisassembleBinaries(*data, *res.code, test_name)) { if (data->size() > res.code->size()) { - LOG(WARNING) << "Assembly code is not identical, but disassembly of machine code is " - "equal: this implies sub-optimal encoding! Our code size=" << data->size() << + // Fail this test with a fancy colored warning being printed. + EXPECT_TRUE(false) << "Assembly code is not identical, but disassembly of machine code " + "is equal: this implies sub-optimal encoding! Our code size=" << data->size() << ", gcc size=" << res.code->size(); } else { + // Otherwise just print an info message and clean up. LOG(INFO) << "GCC chose a different encoding than ours, but the overall length is the " "same."; + Clean(&res); } } else { // This will output the assembly. |