diff options
author | Nicolas Geoffray <ngeoffray@google.com> | 2015-06-22 15:11:58 +0100 |
---|---|---|
committer | Nicolas Geoffray <ngeoffray@google.com> | 2015-06-22 15:11:58 +0100 |
commit | ee39360775066e6b9920348c86ea98bf01d0facf (patch) | |
tree | 26f4e8bb3a4702d82383a2df3a741faaa92a9aff /compiler | |
parent | 042fd00295d21f936ba7a8c16915ce678970e658 (diff) | |
download | art-ee39360775066e6b9920348c86ea98bf01d0facf.zip art-ee39360775066e6b9920348c86ea98bf01d0facf.tar.gz art-ee39360775066e6b9920348c86ea98bf01d0facf.tar.bz2 |
Revert "Add support for inlining already sharpened interface calls. DO NOT MERGE ANYWHERE"
This reverts commit c362782609ca6fbc355ccc9ea9110fe671db9671.
Reverting in order to make a commit that will merge.
bug:21867144
Diffstat (limited to 'compiler')
-rw-r--r-- | compiler/optimizing/inliner.cc | 18 | ||||
-rw-r--r-- | compiler/optimizing/inliner.h | 2 |
2 files changed, 12 insertions, 8 deletions
diff --git a/compiler/optimizing/inliner.cc b/compiler/optimizing/inliner.cc index b984ef7..e517323 100644 --- a/compiler/optimizing/inliner.cc +++ b/compiler/optimizing/inliner.cc @@ -55,7 +55,7 @@ void HInliner::Run() { if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) { // We use the original invoke type to ensure the resolution of the called method // works properly. - if (!TryInline(call, call->GetDexMethodIndex())) { + if (!TryInline(call, call->GetDexMethodIndex(), call->GetOriginalInvokeType())) { if (kIsDebugBuild) { std::string callee_name = PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile()); @@ -69,18 +69,22 @@ void HInliner::Run() { } } -bool HInliner::TryInline(HInvoke* invoke_instruction, uint32_t method_index) const { +bool HInliner::TryInline(HInvoke* invoke_instruction, + uint32_t method_index, + InvokeType invoke_type) const { ScopedObjectAccess soa(Thread::Current()); const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file); - ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); - // We can query the dex cache directly. The verifier has populated it already. - ArtMethod* resolved_method = class_linker->FindDexCache(caller_dex_file)->GetResolvedMethod( - method_index, class_linker->GetImagePointerSize()); + StackHandleScope<3> hs(soa.Self()); + Handle<mirror::DexCache> dex_cache( + hs.NewHandle(caller_compilation_unit_.GetClassLinker()->FindDexCache(caller_dex_file))); + Handle<mirror::ClassLoader> class_loader(hs.NewHandle( + soa.Decode<mirror::ClassLoader*>(caller_compilation_unit_.GetClassLoader()))); + ArtMethod* resolved_method(compiler_driver_->ResolveMethod( + soa, dex_cache, class_loader, &caller_compilation_unit_, method_index, invoke_type)); if (resolved_method == nullptr) { - // Method cannot be resolved if it is in another dex file we do not have access to. VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file); return false; } diff --git a/compiler/optimizing/inliner.h b/compiler/optimizing/inliner.h index 4602e77..831bdf2 100644 --- a/compiler/optimizing/inliner.h +++ b/compiler/optimizing/inliner.h @@ -47,7 +47,7 @@ class HInliner : public HOptimization { static constexpr const char* kInlinerPassName = "inliner"; private: - bool TryInline(HInvoke* invoke_instruction, uint32_t method_index) const; + bool TryInline(HInvoke* invoke_instruction, uint32_t method_index, InvokeType invoke_type) const; bool TryBuildAndInline(ArtMethod* resolved_method, HInvoke* invoke_instruction, uint32_t method_index, |