diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2014-10-23 16:48:06 -0700 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2014-10-27 16:49:43 -0700 |
| commit | 2d2621a1463d2f3f03fa73503fa42e43657cdcfc (patch) | |
| tree | 1f7cf393693d72db5c186f99b04ac511958c6418 /oatdump | |
| parent | ac293277b69882105810fabd6c53f55de58823fe (diff) | |
| download | art-2d2621a1463d2f3f03fa73503fa42e43657cdcfc.zip art-2d2621a1463d2f3f03fa73503fa42e43657cdcfc.tar.gz art-2d2621a1463d2f3f03fa73503fa42e43657cdcfc.tar.bz2 | |
Optimize method linking
Added more inlining, removed imt array allocation and replaced it
with a handle scope. Removed some un-necessary handle scopes.
Added logic to base interface method tables from the superclass so
that we dont need to reconstruct for every interface (large win).
Facebook launch Dalvik KK MR2:
TotalTime: 3165
TotalTime: 3652
TotalTime: 3143
TotalTime: 3298
TotalTime: 3212
TotalTime: 3211
Facebook launch TOT before:
WaitTime: 3702
WaitTime: 3616
WaitTime: 3616
WaitTime: 3687
WaitTime: 3742
WaitTime: 3767
After optimizations:
WaitTime: 2903
WaitTime: 2953
WaitTime: 2918
WaitTime: 2940
WaitTime: 2879
WaitTime: 2792
LinkInterfaceMethods no longer one of the hottest methods, new list:
4.73% art::ClassLinker::LinkVirtualMethods(art::Thread*, art::Handle<art::mirror::Class>)
3.07% art::DexFile::FindClassDef(char const*) const
2.94% art::mirror::Class::FindDeclaredStaticField(art::mirror::DexCache const*, unsigned int)
2.90% art::DexFile::FindStringId(char const*) const
Bug: 18054905
Bug: 16828525
(cherry picked from commit 1fb463e42cf1d67595cff66d19c0f99e3046f4c4)
Change-Id: I27cc70178fd3655fbe5a3178887fcba189d21321
Diffstat (limited to 'oatdump')
| -rw-r--r-- | oatdump/oatdump.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/oatdump/oatdump.cc b/oatdump/oatdump.cc index 14accac..2f91f1d 100644 --- a/oatdump/oatdump.cc +++ b/oatdump/oatdump.cc @@ -112,6 +112,7 @@ static void usage() { const char* image_roots_descriptions_[] = { "kResolutionMethod", "kImtConflictMethod", + "kImtUnimplementedMethod", "kDefaultImt", "kCalleeSaveMethod", "kRefsOnlySaveMethod", @@ -1615,7 +1616,7 @@ class ImageDumper { } } else if (method->IsAbstract() || method->IsCalleeSaveMethod() || method->IsResolutionMethod() || method->IsImtConflictMethod() || - method->IsClassInitializer()) { + method->IsImtUnimplementedMethod() || method->IsClassInitializer()) { DCHECK(method->GetNativeGcMap() == nullptr) << PrettyMethod(method); DCHECK(method->GetMappingTable() == nullptr) << PrettyMethod(method); } else { |