diff options
author | Chih-Hung Hsieh <chh@google.com> | 2014-11-04 14:39:03 -0800 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-11-04 21:29:52 -0800 |
commit | c4f990eab0486be624c271ebe08d4ed6c2783c42 (patch) | |
tree | d7b14f198637a899af294b1634b9daf2aad59af0 /runtime/arch/arm64 | |
parent | b5331ef9bb2ae68c392e5da3da13816bd43e5b1d (diff) | |
download | art-c4f990eab0486be624c271ebe08d4ed6c2783c42.zip art-c4f990eab0486be624c271ebe08d4ed6c2783c42.tar.gz art-c4f990eab0486be624c271ebe08d4ed6c2783c42.tar.bz2 |
Add ATTRIBUTE_UNUSED to unused parameters.
They are reported by Clang compiler.
BUG: 18244071
Change-Id: I3ebf7a9c324490adbf1135f21818c7ad83c83f3d
Diffstat (limited to 'runtime/arch/arm64')
-rw-r--r-- | runtime/arch/arm64/fault_handler_arm64.cc | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/runtime/arch/arm64/fault_handler_arm64.cc b/runtime/arch/arm64/fault_handler_arm64.cc index 687d232..c914d85 100644 --- a/runtime/arch/arm64/fault_handler_arm64.cc +++ b/runtime/arch/arm64/fault_handler_arm64.cc @@ -37,7 +37,8 @@ extern "C" void art_quick_implicit_suspend(); namespace art { -void FaultManager::HandleNestedSignal(int sig, siginfo_t* info, void* context) { +void FaultManager::HandleNestedSignal(int sig ATTRIBUTE_UNUSED, siginfo_t* info ATTRIBUTE_UNUSED, + void* context) { // To match the case used in ARM we return directly to the longjmp function // rather than through a trivial assembly language stub. @@ -51,7 +52,7 @@ void FaultManager::HandleNestedSignal(int sig, siginfo_t* info, void* context) { sc->pc = reinterpret_cast<uintptr_t>(longjmp); } -void FaultManager::GetMethodAndReturnPcAndSp(siginfo_t* siginfo, void* context, +void FaultManager::GetMethodAndReturnPcAndSp(siginfo_t* siginfo ATTRIBUTE_UNUSED, void* context, mirror::ArtMethod** out_method, uintptr_t* out_return_pc, uintptr_t* out_sp) { struct ucontext *uc = reinterpret_cast<struct ucontext *>(context); @@ -82,7 +83,8 @@ void FaultManager::GetMethodAndReturnPcAndSp(siginfo_t* siginfo, void* context, *out_return_pc = sc->pc + 4; } -bool NullPointerHandler::Action(int sig, siginfo_t* info, void* context) { +bool NullPointerHandler::Action(int sig ATTRIBUTE_UNUSED, siginfo_t* info ATTRIBUTE_UNUSED, + void* context) { // The code that looks for the catch location needs to know the value of the // PC at the point of call. For Null checks we insert a GC map that is immediately after // the load/store instruction that might cause the fault. @@ -105,7 +107,8 @@ bool NullPointerHandler::Action(int sig, siginfo_t* info, void* context) { // The offset from r18 is Thread::ThreadSuspendTriggerOffset(). // To check for a suspend check, we examine the instructions that caused // the fault (at PC-4 and PC). -bool SuspensionHandler::Action(int sig, siginfo_t* info, void* context) { +bool SuspensionHandler::Action(int sig ATTRIBUTE_UNUSED, siginfo_t* info ATTRIBUTE_UNUSED, + void* context) { // These are the instructions to check for. The first one is the ldr x0,[r18,#xxx] // where xxx is the offset of the suspend trigger. uint32_t checkinst1 = 0xf9400240 | (Thread::ThreadSuspendTriggerOffset<8>().Int32Value() << 7); @@ -155,7 +158,8 @@ bool SuspensionHandler::Action(int sig, siginfo_t* info, void* context) { return false; } -bool StackOverflowHandler::Action(int sig, siginfo_t* info, void* context) { +bool StackOverflowHandler::Action(int sig ATTRIBUTE_UNUSED, siginfo_t* info ATTRIBUTE_UNUSED, + void* context) { struct ucontext *uc = reinterpret_cast<struct ucontext *>(context); struct sigcontext *sc = reinterpret_cast<struct sigcontext*>(&uc->uc_mcontext); VLOG(signals) << "stack overflow handler with sp at " << std::hex << &uc; |