summaryrefslogtreecommitdiffstats
path: root/runtime/arch/x86/asm_support_x86.S
diff options
context:
space:
mode:
authorIan Rogers <irogers@google.com>2014-03-11 16:29:07 -0700
committerIan Rogers <irogers@google.com>2014-03-11 16:29:07 -0700
commitc6651298ef631d787a17c4f6f751bffe9e748a28 (patch)
treeeac3ef112a805da566e851b2bab535df268ba8f1 /runtime/arch/x86/asm_support_x86.S
parentd46a0b1c6bc5c1058085063f9ada94d5d6708bdc (diff)
downloadart-c6651298ef631d787a17c4f6f751bffe9e748a28.zip
art-c6651298ef631d787a17c4f6f751bffe9e748a28.tar.gz
art-c6651298ef631d787a17c4f6f751bffe9e748a28.tar.bz2
Always reset CFI state.
.cfi_startproc simple may do even less than .cfi_startproc, so don't rely on it. Instead, use regular .cfi_startporc and always set up the expected entry state. Change-Id: I6d3e8b8e4a07621bc99c062359a109eb76f85184
Diffstat (limited to 'runtime/arch/x86/asm_support_x86.S')
-rw-r--r--runtime/arch/x86/asm_support_x86.S3
1 files changed, 1 insertions, 2 deletions
diff --git a/runtime/arch/x86/asm_support_x86.S b/runtime/arch/x86/asm_support_x86.S
index 5bf7c55..e329530 100644
--- a/runtime/arch/x86/asm_support_x86.S
+++ b/runtime/arch/x86/asm_support_x86.S
@@ -104,8 +104,7 @@ MACRO1(DEFINE_FUNCTION, c_name)
ALIGN_FUNCTION_ENTRY
VAR(c_name, 0):
CFI_STARTPROC
- // TODO: we reset the CFA state here. It'd be better to use ".cfi_startproc simple" above but
- // clang 3.4 doesn't support this.
+ // Ensure we get a sane starting CFA.
CFI_DEF_CFA(esp, 4)
END_MACRO