diff options
author | Ian Rogers <irogers@google.com> | 2014-05-29 21:31:50 -0700 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-05-30 12:46:10 -0700 |
commit | 5cf98196d488437acd1e989c08a554ef697fded1 (patch) | |
tree | dd44bc0120562169b701e80dbec413a179862beb /runtime/deoptimize_stack_visitor.cc | |
parent | b7f02280f7f56ae94fe7f01e161be0b725b6e4a9 (diff) | |
download | art-5cf98196d488437acd1e989c08a554ef697fded1.zip art-5cf98196d488437acd1e989c08a554ef697fded1.tar.gz art-5cf98196d488437acd1e989c08a554ef697fded1.tar.bz2 |
Don't report down-calls as unhandled exceptions.
Bug: 15310540
Also, narrow scope of catch/deoptimize stack visitors that are specific to
quick exception delivery.
Change-Id: Ib13a006ce1347acb93a36b0186550d4c3ec2034b
Diffstat (limited to 'runtime/deoptimize_stack_visitor.cc')
-rw-r--r-- | runtime/deoptimize_stack_visitor.cc | 88 |
1 files changed, 0 insertions, 88 deletions
diff --git a/runtime/deoptimize_stack_visitor.cc b/runtime/deoptimize_stack_visitor.cc deleted file mode 100644 index 449ccce..0000000 --- a/runtime/deoptimize_stack_visitor.cc +++ /dev/null @@ -1,88 +0,0 @@ -/* - * Copyright (C) 2014 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#include "deoptimize_stack_visitor.h" - -#include "mirror/art_method-inl.h" -#include "object_utils.h" -#include "quick_exception_handler.h" -#include "handle_scope-inl.h" -#include "verifier/method_verifier.h" - -namespace art { - -bool DeoptimizeStackVisitor::VisitFrame() { - exception_handler_->SetHandlerFrameId(GetFrameId()); - mirror::ArtMethod* method = GetMethod(); - if (method == nullptr) { - // This is the upcall, we remember the frame and last pc so that we may long jump to them. - exception_handler_->SetHandlerQuickFramePc(GetCurrentQuickFramePc()); - exception_handler_->SetHandlerQuickFrame(GetCurrentQuickFrame()); - return false; // End stack walk. - } else if (method->IsRuntimeMethod()) { - // Ignore callee save method. - DCHECK(method->IsCalleeSaveMethod()); - return true; - } else { - return HandleDeoptimization(method); - } -} - -bool DeoptimizeStackVisitor::HandleDeoptimization(mirror::ArtMethod* m) { - MethodHelper mh(m); - const DexFile::CodeItem* code_item = mh.GetCodeItem(); - CHECK(code_item != nullptr); - uint16_t num_regs = code_item->registers_size_; - uint32_t dex_pc = GetDexPc(); - const Instruction* inst = Instruction::At(code_item->insns_ + dex_pc); - uint32_t new_dex_pc = dex_pc + inst->SizeInCodeUnits(); - ShadowFrame* new_frame = ShadowFrame::Create(num_regs, nullptr, m, new_dex_pc); - StackHandleScope<2> hs(self_); - Handle<mirror::DexCache> dex_cache(hs.NewHandle(mh.GetDexCache())); - Handle<mirror::ClassLoader> class_loader(hs.NewHandle(mh.GetClassLoader())); - verifier::MethodVerifier verifier(&mh.GetDexFile(), &dex_cache, &class_loader, - &mh.GetClassDef(), code_item, m->GetDexMethodIndex(), m, - m->GetAccessFlags(), false, true, true); - verifier.Verify(); - std::vector<int32_t> kinds = verifier.DescribeVRegs(dex_pc); - for (uint16_t reg = 0; reg < num_regs; ++reg) { - VRegKind kind = static_cast<VRegKind>(kinds.at(reg * 2)); - switch (kind) { - case kUndefined: - new_frame->SetVReg(reg, 0xEBADDE09); - break; - case kConstant: - new_frame->SetVReg(reg, kinds.at((reg * 2) + 1)); - break; - case kReferenceVReg: - new_frame->SetVRegReference(reg, - reinterpret_cast<mirror::Object*>(GetVReg(m, reg, kind))); - break; - default: - new_frame->SetVReg(reg, GetVReg(m, reg, kind)); - break; - } - } - if (prev_shadow_frame_ != nullptr) { - prev_shadow_frame_->SetLink(new_frame); - } else { - self_->SetDeoptimizationShadowFrame(new_frame); - } - prev_shadow_frame_ = new_frame; - return true; -} - -} // namespace art |