summaryrefslogtreecommitdiffstats
path: root/runtime/fault_handler.cc
diff options
context:
space:
mode:
authorBrian Carlstrom <bdc@google.com>2014-05-08 19:05:29 -0700
committerBrian Carlstrom <bdc@google.com>2014-05-09 12:23:00 -0700
commit4d466a8e4587422c989705dce3b2a19e7f0137f5 (patch)
treebd8f0f45db9a7d5888b14a070690f59fb599bd68 /runtime/fault_handler.cc
parentf1c036fc8fa97617cc42bda44a0adbc7b856d6cd (diff)
downloadart-4d466a8e4587422c989705dce3b2a19e7f0137f5.zip
art-4d466a8e4587422c989705dce3b2a19e7f0137f5.tar.gz
art-4d466a8e4587422c989705dce3b2a19e7f0137f5.tar.bz2
Remove all LOG(DEBUG) which is not intended to be checked in
Bug: 14632493 Change-Id: Id9da8b87798af0a1b2bd2c178133e5f1ba47d43d
Diffstat (limited to 'runtime/fault_handler.cc')
-rw-r--r--runtime/fault_handler.cc10
1 files changed, 7 insertions, 3 deletions
diff --git a/runtime/fault_handler.cc b/runtime/fault_handler.cc
index 283faa2..c457f12 100644
--- a/runtime/fault_handler.cc
+++ b/runtime/fault_handler.cc
@@ -67,11 +67,15 @@ void FaultManager::Init() {
}
void FaultManager::HandleFault(int sig, siginfo_t* info, void* context) {
- LOG(DEBUG) << "Handling fault";
+ // BE CAREFUL ALLOCATING HERE INCLUDING USING LOG(...)
+ //
+ // If malloc calls abort, it will be holding its lock.
+ // If the handler tries to call malloc, it will deadlock.
+ VLOG(signals) << "Handling fault";
if (IsInGeneratedCode(context, true)) {
- LOG(DEBUG) << "in generated code, looking for handler";
+ VLOG(signals) << "in generated code, looking for handler";
for (const auto& handler : generated_code_handlers_) {
- LOG(DEBUG) << "invoking Action on handler " << handler;
+ VLOG(signals) << "invoking Action on handler " << handler;
if (handler->Action(sig, info, context)) {
return;
}