diff options
author | Mathieu Chartier <mathieuc@google.com> | 2014-01-07 16:00:07 -0800 |
---|---|---|
committer | Mathieu Chartier <mathieuc@google.com> | 2014-01-07 16:32:26 -0800 |
commit | ec05007f8619f8b0cc868d06731e07f84bb74c5b (patch) | |
tree | 5ead8619ecdde844b0e0af2e2a790e50c331fe7a /runtime/gc/collector/mark_sweep.h | |
parent | 5a2ced515a456f15dcf194843c024e835eda7dbe (diff) | |
download | art-ec05007f8619f8b0cc868d06731e07f84bb74c5b.zip art-ec05007f8619f8b0cc868d06731e07f84bb74c5b.tar.gz art-ec05007f8619f8b0cc868d06731e07f84bb74c5b.tar.bz2 |
Refactor sweeping logic into malloc space.
Removes duplicated code in MarkSweep/SemiSpace.
Deleted VerifyImageRoots since it had race conditions and is tested
by pre/post GC heap verification.
Change-Id: I9636359ff6adb3e93d56ce77a3e15299ed23dfd5
Diffstat (limited to 'runtime/gc/collector/mark_sweep.h')
-rw-r--r-- | runtime/gc/collector/mark_sweep.h | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/runtime/gc/collector/mark_sweep.h b/runtime/gc/collector/mark_sweep.h index 62991bb..e2eafb5 100644 --- a/runtime/gc/collector/mark_sweep.h +++ b/runtime/gc/collector/mark_sweep.h @@ -100,11 +100,6 @@ class MarkSweep : public GarbageCollector { EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); - // Verify that image roots point to only marked objects within the alloc space. - void VerifyImageRoots() - EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) - SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); - // Builds a mark stack and recursively mark until it empties. void RecursiveMark() EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_) @@ -251,20 +246,6 @@ class MarkSweep : public GarbageCollector { // Returns true if we need to add obj to a mark stack. bool MarkObjectParallel(const mirror::Object* obj) NO_THREAD_SAFETY_ANALYSIS; - static void SweepCallback(size_t num_ptrs, mirror::Object** ptrs, void* arg) - EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_); - - // Special sweep for zygote that just marks objects / dirties cards. - static void ZygoteSweepCallback(size_t num_ptrs, mirror::Object** ptrs, void* arg) - EXCLUSIVE_LOCKS_REQUIRED(Locks::heap_bitmap_lock_); - - void CheckReference(const mirror::Object* obj, const mirror::Object* ref, MemberOffset offset, - bool is_static) - SHARED_LOCKS_REQUIRED(Locks::heap_bitmap_lock_, Locks::mutator_lock_); - - void CheckObject(const mirror::Object* obj) - SHARED_LOCKS_REQUIRED(Locks::heap_bitmap_lock_, Locks::mutator_lock_); - // Verify the roots of the heap and print out information related to any invalid roots. // Called in MarkObject, so may we may not hold the mutator lock. void VerifyRoots() |