diff options
author | Mathieu Chartier <mathieuc@google.com> | 2014-04-09 17:54:10 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2014-04-09 17:54:10 +0000 |
commit | dc9009e32d3c94e42614245fdf3fa024a5721aec (patch) | |
tree | fb6e3d1f6ea62027080730a54a575b37d967e3a9 /runtime/gc | |
parent | 8edd574b5105f714961159ee5f8d04a264ae83eb (diff) | |
parent | df86d1f8147a95c1ec2f0c5d85e0439ef7d71730 (diff) | |
download | art-dc9009e32d3c94e42614245fdf3fa024a5721aec.zip art-dc9009e32d3c94e42614245fdf3fa024a5721aec.tar.gz art-dc9009e32d3c94e42614245fdf3fa024a5721aec.tar.bz2 |
Merge "Adjust sticky GC ergonomics."
Diffstat (limited to 'runtime/gc')
-rw-r--r-- | runtime/gc/heap.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/runtime/gc/heap.cc b/runtime/gc/heap.cc index eb8c7b1..72b8449 100644 --- a/runtime/gc/heap.cc +++ b/runtime/gc/heap.cc @@ -77,6 +77,10 @@ static constexpr size_t kGcAlotInterval = KB; // Minimum amount of remaining bytes before a concurrent GC is triggered. static constexpr size_t kMinConcurrentRemainingBytes = 128 * KB; static constexpr size_t kMaxConcurrentRemainingBytes = 512 * KB; +// Sticky GC throughput adjustment, divided by 4. Increasing this causes sticky GC to occur more +// relative to partial/full GC. This is desirable since sticky GCs interfere less with mutator +// threads (lower pauses, use less memory bandwidth). +static constexpr double kStickyGcThroughputAdjustment = 1.25; Heap::Heap(size_t initial_size, size_t growth_limit, size_t min_free, size_t max_free, double target_utilization, size_t capacity, const std::string& image_file_name, @@ -2546,7 +2550,7 @@ void Heap::GrowForUtilization(collector::GarbageCollector* collector_ran) { // We also check that the bytes allocated aren't over the footprint limit in order to prevent a // pathological case where dead objects which aren't reclaimed by sticky could get accumulated // if the sticky GC throughput always remained >= the full/partial throughput. - if (collector_ran->GetEstimatedLastIterationThroughput() >= + if (collector_ran->GetEstimatedLastIterationThroughput() * kStickyGcThroughputAdjustment >= non_sticky_collector->GetEstimatedMeanThroughput() && non_sticky_collector->GetIterations() > 0 && bytes_allocated <= max_allowed_footprint_) { |