diff options
author | Ian Rogers <irogers@google.com> | 2013-10-01 19:45:43 -0700 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2013-10-02 09:31:55 -0700 |
commit | d9c4fc94fa618617f94e1de9af5f034549100753 (patch) | |
tree | 1305efbbc3d4bc306c0947bb6d4b01553667f98e /runtime/mirror/class.cc | |
parent | 7ef126ce0593929bcf8fb73d8b1119ce3b95b3f2 (diff) | |
download | art-d9c4fc94fa618617f94e1de9af5f034549100753.zip art-d9c4fc94fa618617f94e1de9af5f034549100753.tar.gz art-d9c4fc94fa618617f94e1de9af5f034549100753.tar.bz2 |
Inflate contended lock word by suspending owner.
Bug 6961405.
Don't inflate monitors for Notify and NotifyAll.
Tidy lock word, handle recursive lock case alongside unlocked case and move
assembly out of line (except for ARM quick). Also handle null in out-of-line
assembly as the test is quick and the enter/exit code is already a safepoint.
To gain ownership of a monitor on behalf of another thread, monitor contenders
must not hold the monitor_lock_, so they wait on a condition variable.
Reduce size of per mutex contention log.
Be consistent in calling thin lock thread ids just thread ids.
Fix potential thread death races caused by the use of FindThreadByThreadId,
make it invariant that returned threads are either self or suspended now.
Code size reduction on ARM boot.oat 0.2%.
Old nexus 7 speedup 0.25%, new nexus 7 speedup 1.4%, nexus 10 speedup 2.24%,
nexus 4 speedup 2.09% on DeltaBlue.
Change-Id: Id52558b914f160d9c8578fdd7fc8199a9598576a
Diffstat (limited to 'runtime/mirror/class.cc')
-rw-r--r-- | runtime/mirror/class.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runtime/mirror/class.cc b/runtime/mirror/class.cc index c6db5b9..b16c2f7 100644 --- a/runtime/mirror/class.cc +++ b/runtime/mirror/class.cc @@ -60,7 +60,7 @@ void Class::SetStatus(Status new_status, Thread* self) { } if (new_status >= kStatusResolved || old_status >= kStatusResolved) { // When classes are being resolved the resolution code should hold the lock. - CHECK_EQ(GetThinLockId(), self->GetThinLockId()) + CHECK_EQ(GetLockOwnerThreadId(), self->GetThreadId()) << "Attempt to change status of class while not holding its lock: " << PrettyClass(this) << " " << old_status << " -> " << new_status; } |