diff options
| author | Alexei Zavjalov <alexei.zavjalov@intel.com> | 2014-06-12 03:08:01 +0700 |
|---|---|---|
| committer | Alexei Zavjalov <alexei.zavjalov@intel.com> | 2014-06-17 13:22:50 +0700 |
| commit | bd3682eada753de52975ae2b4a712bd87dc139a6 (patch) | |
| tree | c479068b294328afb3fc83b127eb6f725552717d /runtime | |
| parent | eaac24f37a814c54073ef438cf93f2181464b562 (diff) | |
| download | art-bd3682eada753de52975ae2b4a712bd87dc139a6.zip art-bd3682eada753de52975ae2b4a712bd87dc139a6.tar.gz art-bd3682eada753de52975ae2b4a712bd87dc139a6.tar.bz2 | |
ART: Implement rem_double/rem_float for x86/x86-64
This adds inlined version of the rem_double/rem_float bytecodes
for x86/x86-64 platforms. This patch also removes unnecessary
fmod and fmodf stubs from runtime.
Change-Id: I2311aa2adf08d6614527e0da070e3b6ce2343a20
Signed-off-by: Alexei Zavjalov <alexei.zavjalov@intel.com>
Diffstat (limited to 'runtime')
| -rw-r--r-- | runtime/arch/x86/entrypoints_init_x86.cc | 6 | ||||
| -rw-r--r-- | runtime/arch/x86/quick_entrypoints_x86.S | 29 | ||||
| -rw-r--r-- | runtime/arch/x86_64/entrypoints_init_x86_64.cc | 4 |
3 files changed, 4 insertions, 35 deletions
diff --git a/runtime/arch/x86/entrypoints_init_x86.cc b/runtime/arch/x86/entrypoints_init_x86.cc index c30dca1..a85e250 100644 --- a/runtime/arch/x86/entrypoints_init_x86.cc +++ b/runtime/arch/x86/entrypoints_init_x86.cc @@ -69,8 +69,6 @@ extern "C" void art_quick_lock_object(void*); extern "C" void art_quick_unlock_object(void*); // Math entrypoints. -extern "C" double art_quick_fmod(double, double); -extern "C" float art_quick_fmodf(float, float); extern "C" int64_t art_quick_d2l(double); extern "C" int64_t art_quick_f2l(float); extern "C" int64_t art_quick_ldiv(int64_t, int64_t); @@ -175,9 +173,9 @@ void InitEntryPoints(InterpreterEntryPoints* ipoints, JniEntryPoints* jpoints, // points->pCmpgFloat = NULL; // Not needed on x86. // points->pCmplDouble = NULL; // Not needed on x86. // points->pCmplFloat = NULL; // Not needed on x86. - qpoints->pFmod = art_quick_fmod; + // qpoints->pFmod = NULL; // Not needed on x86. // qpoints->pL2d = NULL; // Not needed on x86. - qpoints->pFmodf = art_quick_fmodf; + // qpoints->pFmodf = NULL; // Not needed on x86. // qpoints->pL2f = NULL; // Not needed on x86. // points->pD2iz = NULL; // Not needed on x86. // points->pF2iz = NULL; // Not needed on x86. diff --git a/runtime/arch/x86/quick_entrypoints_x86.S b/runtime/arch/x86/quick_entrypoints_x86.S index 28e4dd6..ecd8ce6 100644 --- a/runtime/arch/x86/quick_entrypoints_x86.S +++ b/runtime/arch/x86/quick_entrypoints_x86.S @@ -734,35 +734,6 @@ END_FUNCTION art_quick_memcpy NO_ARG_DOWNCALL art_quick_test_suspend, artTestSuspendFromCode, ret -DEFINE_FUNCTION art_quick_fmod - subl LITERAL(12), %esp // alignment padding - CFI_ADJUST_CFA_OFFSET(12) - PUSH ebx // pass arg4 b.hi - PUSH edx // pass arg3 b.lo - PUSH ecx // pass arg2 a.hi - PUSH eax // pass arg1 a.lo - SETUP_GOT_NOSAVE // clobbers EBX - call PLT_SYMBOL(fmod) // (jdouble a, jdouble b) - fstpl (%esp) // pop return value off fp stack - movsd (%esp), %xmm0 // place into %xmm0 - addl LITERAL(28), %esp // pop arguments - CFI_ADJUST_CFA_OFFSET(-28) - ret -END_FUNCTION art_quick_fmod - -DEFINE_FUNCTION art_quick_fmodf - PUSH eax // alignment padding - PUSH ecx // pass arg2 b - PUSH eax // pass arg1 a - SETUP_GOT_NOSAVE // clobbers EBX - call PLT_SYMBOL(fmodf) // (jfloat a, jfloat b) - fstps (%esp) // pop return value off fp stack - movss (%esp), %xmm0 // place into %xmm0 - addl LITERAL(12), %esp // pop arguments - CFI_ADJUST_CFA_OFFSET(-12) - ret -END_FUNCTION art_quick_fmodf - DEFINE_FUNCTION art_quick_d2l PUSH eax // alignment padding PUSH ecx // pass arg2 a.hi diff --git a/runtime/arch/x86_64/entrypoints_init_x86_64.cc b/runtime/arch/x86_64/entrypoints_init_x86_64.cc index 2612417..92aabee 100644 --- a/runtime/arch/x86_64/entrypoints_init_x86_64.cc +++ b/runtime/arch/x86_64/entrypoints_init_x86_64.cc @@ -174,9 +174,9 @@ void InitEntryPoints(InterpreterEntryPoints* ipoints, JniEntryPoints* jpoints, // points->pCmpgFloat = NULL; // Not needed on x86. // points->pCmplDouble = NULL; // Not needed on x86. // points->pCmplFloat = NULL; // Not needed on x86. - qpoints->pFmod = fmod; + // qpoints->pFmod = NULL; // Not needed on x86. // qpoints->pL2d = NULL; // Not needed on x86. - qpoints->pFmodf = fmodf; + // qpoints->pFmodf = NULL; // Not needed on x86. // qpoints->pL2f = NULL; // Not needed on x86. // points->pD2iz = NULL; // Not needed on x86. // points->pF2iz = NULL; // Not needed on x86. |