summaryrefslogtreecommitdiffstats
path: root/src/java_lang_reflect_Array.cc
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2012-03-15 22:10:52 -0700
committerElliott Hughes <enh@google.com>2012-03-15 22:10:52 -0700
commit0512f02dd6623c0870c11fbf3274d7462f732136 (patch)
treec90b32c42b285d3cea45272601b5cf007b4ea264 /src/java_lang_reflect_Array.cc
parent88c5c355fc3d881f905564911d746b2313d5fc89 (diff)
downloadart-0512f02dd6623c0870c11fbf3274d7462f732136.zip
art-0512f02dd6623c0870c11fbf3274d7462f732136.tar.gz
art-0512f02dd6623c0870c11fbf3274d7462f732136.tar.bz2
Remove anonymous namespaces.
No one likes them and we're pretty inconsistent at using them. We're much better with 'static'. Change-Id: I65eeffd0fb60633edca30923af0caedb06a0105d
Diffstat (limited to 'src/java_lang_reflect_Array.cc')
-rw-r--r--src/java_lang_reflect_Array.cc12
1 files changed, 3 insertions, 9 deletions
diff --git a/src/java_lang_reflect_Array.cc b/src/java_lang_reflect_Array.cc
index 3bf2680..4a5f797 100644
--- a/src/java_lang_reflect_Array.cc
+++ b/src/java_lang_reflect_Array.cc
@@ -23,12 +23,9 @@
namespace art {
-namespace {
-
-
// Recursively create an array with multiple dimensions. Elements may be
// Objects or primitive types.
-Array* CreateMultiArray(Class* array_class, int current_dimension, IntArray* dimensions) {
+static Array* CreateMultiArray(Class* array_class, int current_dimension, IntArray* dimensions) {
int32_t array_length = dimensions->Get(current_dimension++);
SirtRef<Array> new_array(Array::Alloc(array_class, array_length));
if (new_array.get() == NULL) {
@@ -72,7 +69,7 @@ Array* CreateMultiArray(Class* array_class, int current_dimension, IntArray* dim
// easiest way to deal with that is to create the full name once and then
// subtract pieces off. Besides, we want to start with the outermost
// piece and work our way in.
-jobject Array_createMultiArray(JNIEnv* env, jclass, jclass javaElementClass, jobject javaDimArray) {
+static jobject Array_createMultiArray(JNIEnv* env, jclass, jclass javaElementClass, jobject javaDimArray) {
ScopedThreadStateChange tsc(Thread::Current(), Thread::kRunnable);
DCHECK(javaElementClass != NULL);
Class* element_class = Decode<Class*>(env, javaElementClass);
@@ -120,8 +117,7 @@ jobject Array_createMultiArray(JNIEnv* env, jclass, jclass javaElementClass, job
return AddLocalReference<jobject>(env, new_array);
}
-jobject Array_createObjectArray(JNIEnv* env, jclass, jclass javaElementClass, jint length)
-{
+static jobject Array_createObjectArray(JNIEnv* env, jclass, jclass javaElementClass, jint length) {
ScopedThreadStateChange tsc(Thread::Current(), Thread::kRunnable);
DCHECK(javaElementClass != NULL);
Class* element_class = Decode<Class*>(env, javaElementClass);
@@ -153,8 +149,6 @@ static JNINativeMethod gMethods[] = {
NATIVE_METHOD(Array, createObjectArray, "(Ljava/lang/Class;I)Ljava/lang/Object;"),
};
-} // namespace
-
void register_java_lang_reflect_Array(JNIEnv* env) {
jniRegisterNativeMethods(env, "java/lang/reflect/Array", gMethods, NELEM(gMethods));
}