diff options
author | Ian Rogers <irogers@google.com> | 2013-06-07 22:37:45 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2013-06-07 22:37:45 +0000 |
commit | 78ffecc0ad1f47b1551ee575811c610b62e08d98 (patch) | |
tree | d24c2777476f6ce7f0f57ab18a40c54cd8e8046e /src | |
parent | ece6c6e7f31db4a25a6f1f95edffdf445032d8c5 (diff) | |
parent | 6fe568e16cea80dfe9ccb856c138a75da5f2a90d (diff) | |
download | art-78ffecc0ad1f47b1551ee575811c610b62e08d98.zip art-78ffecc0ad1f47b1551ee575811c610b62e08d98.tar.gz art-78ffecc0ad1f47b1551ee575811c610b62e08d98.tar.bz2 |
Merge "Simplify CanAssumeTypeIsPresentInDexCache." into dalvik-dev
Diffstat (limited to 'src')
-rw-r--r-- | src/compiler/driver/compiler_driver.cc | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/src/compiler/driver/compiler_driver.cc b/src/compiler/driver/compiler_driver.cc index 834be64..40cc483 100644 --- a/src/compiler/driver/compiler_driver.cc +++ b/src/compiler/driver/compiler_driver.cc @@ -597,24 +597,19 @@ void CompilerDriver::RecordClassStatus(ClassReference ref, CompiledClass* compil bool CompilerDriver::CanAssumeTypeIsPresentInDexCache(const DexFile& dex_file, uint32_t type_idx) { - ScopedObjectAccess soa(Thread::Current()); - mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file); - if (!IsImage()) { - stats_->TypeNotInDexCache(); - return false; - } - mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx); - if (resolved_class == NULL) { - stats_->TypeNotInDexCache(); - return false; - } - bool result = IsImageClass(ClassHelper(resolved_class).GetDescriptor()); - if (result) { + if (IsImage() && IsImageClass(dex_file.GetTypeDescriptor(dex_file.GetTypeId(type_idx)))) { + if (kIsDebugBuild) { + ScopedObjectAccess soa(Thread::Current()); + mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file); + mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx); + CHECK(resolved_class != NULL); + } stats_->TypeInDexCache(); + return true; } else { stats_->TypeNotInDexCache(); + return false; } - return result; } bool CompilerDriver::CanAssumeStringIsPresentInDexCache(const DexFile& dex_file, |