summaryrefslogtreecommitdiffstats
path: root/compiler
Commit message (Collapse)AuthorAgeFilesLines
* ART: Fix Quick/Optimizing suspend check assumption mismatch.Vladimir Marko2015-07-233-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | Quick's SuspendCheckElimination (SCE) expects that every method contains a suspend check and it eliminates suspend checks in loops containing an invoke. Optimizing eliminates the suspend check from leaf methods, so the combination of a Quick-compiled loop calling an Optimizing-compiled leaf method can lead to missing suspend checks and potentially leading to ANRs. Enable Quick's kLeafOptimization flag to remove suspend checks from leaf methods and disable Quick's SCE. This aligns the suspend check placement for the two backends and avoids the broken combination. Currently, all methods containing a try-catch are compiled with Quick, so it's relatively easy to create a regression test. However, this test will not be valid when Optimizing starts supporting try-catch. Bug: 22657404 (cherry picked from commit d29e8487ff1774b6eb5f0e18d854415c1ee8f6b0) Change-Id: I733c38bf68bfc2c618f2f2e6b59f8b0e015d7be1
* Reduce space filter threshold to 128.Nicolas Geoffray2015-07-171-2/+2
| | | | | | | | | | In order to get closer to our code increase limit. Bug:21868508 (cherry picked from commit 432bf3d525dd0736c91238d69e29b4db6a2f7b80) Change-Id: Iab19fe99a8a869b0fb841bac317016e4a3dc00e2
* Merge "ART: Boolean simplifier fix" into mnc-devNicolas Geoffray2015-07-171-5/+0
|\
| * ART: Boolean simplifier fixSerguei Katkov2015-07-161-5/+0
| | | | | | | | | | | | | | | | | | Boolean simplifier should not remove condition instruction if it has side effects. (cherry picked from commit 108ceb48edea654c544b483c302212e43d79a472) Change-Id: I00dd595da1bba0f027f5c8647035e9fd8ba62ee1
* | ART: DCE should know that array-length can throw NPESerguei Katkov2015-07-162-1/+34
|/ | | | | | | | | | | array-length can throw NPE so it should be taking into account. Bug: 22521944 Signed-off-by: Serguei Katkov <serguei.i.katkov@intel.com> (cherry picked from commit b016c6dd3c30b04104a0a43dc294ce93e5f63874) Change-Id: I6232430a02f9e6d156ad2aae0eb5a630118c0e79
* Merge "ART: Release inputs in Long.reverse intrinsic in x86" into mnc-devAndreas Gampe2015-07-081-0/+15
|\
| * ART: Release inputs in Long.reverse intrinsic in x86Andreas Gampe2015-07-081-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | In the worst case we are using two temps each for input and output. Then we do not have a temp left over for the swap operations. The input is dead, however, after the first swap. So try to release it (a no-op if it isn't actually a temp). Bug: 22324327 (cherry picked from commit 575422fa5be7389bdaff5e2d25dd87b1d2d4de85) Change-Id: I1fc50159afdad14160e34abeaf4670958171d6b2
* | ART: Fix opsize in LoadArgDirectAndreas Gampe2015-07-071-1/+2
|/ | | | | | | | | | | If the destination register is a reference, use kReference for the op size. Bug: 22244733 (cherry picked from commit 185a5586c8b796e770e9b4b7ac2befa8ccdaca7e) Change-Id: Idf52f2ee4c65b5dc41cb66257d95281dc6f32255
* Add implicit null pointer and stack overflow checks for Mips.Douglas Leung2015-07-035-5/+48
| | | | | | | (cherry picked from commit 22bb5a2ebc1e2724179faf4660b2735dcb185f21) Bug: 21555893 Change-Id: I2a995be128a5603d08753c14956dd8c8240ac63c
* Do not create a HBoundType when the instruction is non-null.Nicolas Geoffray2015-07-022-0/+8
| | | | | | | | | | We don't need to refine the type after a null check, if the instruction is known non null or null. As a side effect, this avoids replacing HLoadClass instructions with HBoundType instructions. bug:22116987 Change-Id: I565ae95db5a64faec30e026674636e398e0bf445
* Merge "ART: Fix data loss when symbolizing oat files." into mnc-devAndreas Gampe2015-07-012-6/+10
|\
| * ART: Fix data loss when symbolizing oat files.Zheng Xu2015-07-012-6/+10
| | | | | | | | | | | | | | | | Bug: 21760614 (cherry picked from commit 98088c424efd45ea3c172d4bc16e191f26a007cc) Change-Id: I1b40b8ee313a4d187439d969d083d12fb3997cda
* | Merge "Do not replace a live phi with a dead phi." into mnc-devNicolas Geoffray2015-07-011-1/+7
|\ \
| * | Do not replace a live phi with a dead phi.Nicolas Geoffray2015-06-291-1/+7
| |/ | | | | | | | | | | | | | | | | | | | | A dead phi is not properly typed. Therefore, always use the live phi equivalent instead. bug:21865466 (cherry picked from commit 4230e1895b915a22363452823b0e51eabe92cb60) Change-Id: If9a3313fc953c2eb4be85b625676e48112fcb1f6
* | Revert "Revert "Do not update the type of something we already know.""Nicolas Geoffray2015-06-293-0/+37
|/ | | | | | | | | | This reverts commit 63107a804ce17db9789051e1fe310d99d1dae1cb. bug:22116987 (cherry picked from commit f9a199571417b5a5a62d94d05a064077e14dd2c4) Change-Id: Ia516f2cbce6d22df37f3a0854abdd0b54d3ea72d
* Merge "MIPS: Initial version of optimizing compiler for MIPS64R6." into mnc-devRoland Levillain2015-06-2913-254/+4415
|\
| * MIPS: Initial version of optimizing compiler for MIPS64R6.Roland Levillain2015-06-2613-254/+4415
| | | | | | | | | | | | | | | | | | | | (cherry picked from commit 4dda3376b71209fae07f5c3c8ac3eb4b54207aa8) (amended for mnc-dev) Bug: 21555893 Change-Id: I874dc356eee6ab061a32f8f3df5f8ac3a4ab7dcf Signed-off-by: Alexey Frunze <Alexey.Frunze@imgtec.com> Signed-off-by: Douglas Leung <douglas.leung@imgtec.com>
* | Quick: Disable GVN, DCE and LVN for type conflicts.Vladimir Marko2015-06-271-5/+11
| | | | | | | | | | | | | | (cherry picked from commit f7e7327d7a873d21aaae01471f46a4d64d65433b) Bug: 22136903 Change-Id: I657d4b5e623696e1264c2c6c9ad4e7fd466d759c
* | ART: Bail out immediately on try/catchDavid Brazdil2015-06-261-6/+11
|/ | | | | | | | | Optimizing builds the graph even if it knows it will delegate to Quick. This patch moves the decision at the beginning of the TryCompile function to save a little bit of compile time. Bug: 22115561 Change-Id: I18b5a686e10592080ea3c49d53a0dd81aa3b3010
* Merge "ART: Fix kEverything compiler filter" into mnc-devAndreas Gampe2015-06-262-3/+4
|\
| * ART: Fix kEverything compiler filterbuzbee2015-06-252-3/+4
| | | | | | | | | | | | | | | | | | | | | | Previously the kEverything filter failed to compile class initializers. Now it will. Bug: 19576257 (cherry picked from commit c83329952b4a313e747c8835a73699e2cae5a6e2) Change-Id: I189d2b5b379aee112c4e95f8d3e6c32abab6ed41
* | ART: Set methods to preverified in verify-noneAndreas Gampe2015-06-251-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | Actually mark all methods to be verified, so that the interpreter doesn't do access checks. Speedup is about 2x on a Nexus 6 when booting in verify-none mode. Bug: 22040916 (cherry picked from commit 1c284f2abdfe1b0ed87d5216021e69146f10b116) Change-Id: I2d6c8df2a68eae6e358da2639d980cb8bfcc1560
* | Only do some checks when compiling against the core image.Nicolas Geoffray2015-06-253-2/+14
| | | | | | | | | | | | | | | | | | | | This will avoid false negatives when running dex2oatd on apks. bug:21865473 (cherry picked from commit 335005e2b3a179f26b7a8ae64ca60a1406b669bd) Change-Id: Iac6dbe30c9d576077a0384b88696f79937d89471
* | [MIPS64] JNI Compiler: Sign-extend int function argumentsLazar Trsic2015-06-242-4/+50
|/ | | | | | | | | | | | | | | MIPS n64 ABI differs from arm64. Arguments smaller than the 8B stack slot need to be sign-extended. Use combination (lw,sd), instead of (lw,sw) for 4B values. Change fixes software keyboard crash on mips64. Bug: 21555893 (cherry picked from commit f652d605753f1387e7797461b47116c5dcdf928d) Change-Id: I7574d37f6039e9e8c9e0047254be71d28d4c829a
* Use a flag from the verifier to know if we should compile.Nicolas Geoffray2015-06-244-1/+13
| | | | | | | | | | | Only used for the lack of bottom type in the aget-object case for now. Could be used for more. bug:21865466 (cherry picked from commit 4824c27988c8eeb302791624bb3ce1d557b0db6c) Change-Id: I2bb7fe1d4737bd92c1076b5193607d74d8761ee7
* BCE: don't assume a bounds check always gets a HArrayLength.Nicolas Geoffray2015-06-241-2/+8
| | | | | | | | | | Deoptimizations may change it to a HPhi. bug:22056703 (cherry picked from commit 8df886b9214802ad689316a1dedb00a6d102555c) Change-Id: I8afcf88e3a12dbe4d87101e6a7cefb8b81e2bb96
* Fix codegen_test after DCE fix.Nicolas Geoffray2015-06-241-1/+4
| | | | | | | | (cherry picked from commit ea80942c39cb5e9bc3e38a388583d1646c1e2a3f) bug:22031382 Change-Id: If410045779adb9e7e611af22c988232b5bf9a902
* Recompute dominator tree after DCE.Nicolas Geoffray2015-06-244-21/+39
| | | | | | | | bug:22031382 (cherry picked from commit 1f82ecc6a0c9f88d03d6d1a6d95eeb8707bd06c1) Change-Id: I9a74edb185cb806045903dfe9695d9cc1a02e86b
* BCE: Narrow instead of unconditionnaly overwrite the range.Nicolas Geoffray2015-06-241-3/+5
| | | | | | | | bug:21862741 (cherry picked from commit a09ff9c11f07863ac57e6120a824f0d20dfaa284) Change-Id: Ia8e903e09a7f9c2b8ef7cf3522f73f154534b81f
* Fix another case of un-verified dead code.Nicolas Geoffray2015-06-241-2/+7
| | | | | | | | | bug:22042796 https://code.google.com/p/android/issues/detail?id=178008 (cherry picked from commit 1efcc22cd1895c48adccbe49270d8e8583c2b12d) Change-Id: I5c0d783e842da39cd3dcbb2f18ccf784e797a64f
* Do not overwrite an input register in shift operations.Nicolas Geoffray2015-06-232-20/+23
| | | | | | | | | | | 'second_reg' is an input register that can survive the instruction. Instead use the output register as a temporary result. bug:21667432 (cherry picked from commit a4f3581da73b83484a30ab499c4f8ad43b378dab) Change-Id: Ic1f399964911b8a9fc57352130c92b2a0a1b8e0d
* ART: Don't do pre-linked calls to the interpreter bridge.Vladimir Marko2015-06-221-1/+3
| | | | | | | | Bug: 21897404 (cherry picked from commit c08ab29796eeaa3b5863fbd987cd96fe7538d40c) Change-Id: I66531379fb4468a8ddee063e664bf6593abbe7d5
* Revert "Revert "Add support for inlining already sharpened interface calls.""Nicolas Geoffray2015-06-222-12/+8
| | | | | | | | bug:21867144 This reverts commit ee39360775066e6b9920348c86ea98bf01d0facf. Change-Id: I69bf85ce7c352b1a22f36f0f2a136f95b4e73bd6
* Revert "Add support for inlining already sharpened interface calls. DO NOT ↵Nicolas Geoffray2015-06-222-8/+12
| | | | | | | | | | MERGE ANYWHERE" This reverts commit c362782609ca6fbc355ccc9ea9110fe671db9671. Reverting in order to make a commit that will merge. bug:21867144
* Revert "Revert "Use IsAssignableFrom instead of IsSubclass for robustness.""Nicolas Geoffray2015-06-222-3/+6
| | | | | | | | | | | | | | | Don't use IsAssignableFrom, but check beforehand if the referrer is an interface. Otherwise, we are being too aggressive on removing clinit checks on interfaces (being a subclass doesn't imply the interface has been initialized). bug:21870666 This reverts commit 463580ca5a1e75e27ad0207537ffc6252091326a. (cherry picked from commit b783b408112d1797da646f576a40f94bcb5162f3) Change-Id: Ida03f453c9b0d4dda87a5696098f9ffbd69a3aa3
* Use compiling class instead of outer class for access checks.Nicolas Geoffray2015-06-221-10/+13
| | | | | | | | bug:21869678 (cherry picked from commit afd06414598e011693137ba044e38756609b2179) Change-Id: I982ccdf46e3f4d0cc1901439e0bc2dcfa0fc661f
* Use compiling class instead of referrer for access checks.Nicolas Geoffray2015-06-222-14/+26
| | | | | | | | bug:21869670 (cherry picked from commit 30451743493bc2f589e96d68ab98f557461f97f9) Change-Id: Ia18986797d166470801e7a9a690c054d2dc57952
* Be careful with predecessor/successor index.Nicolas Geoffray2015-06-225-14/+29
| | | | | | | | | | | | | When we simplify the CFG, we must preserve things that were already simplified. For example, the index in the predecessor list or successor list of a block must be preserved for ensuring the first block is a loop pre header. bug:21867463 (cherry picked from commit 8b20f88b0a8d1b374dd5eaae289d19734c77b8f8) Change-Id: I2581b5a50942290da96cd9ec876f6f2573e0a6c4
* Merge "Don't check the return type in the builder." into mnc-devNicolas Geoffray2015-06-221-5/+0
|\
| * Don't check the return type in the builder.Nicolas Geoffray2015-06-221-5/+0
| | | | | | | | | | | | | | | | | | | | | | The verifier will not complain about dead code. For the compiler, it is benign. bug:21863767 (cherry picked from commit 69505f86a1a653bf86c1f2b423b3e0605137d5d1) Change-Id: I2bc7888b39c91862c6dade130eccdf92f19b3f6f
* | Do not expect 0 or 1 only when comparing a boolean.Nicolas Geoffray2015-06-221-4/+6
|/ | | | | | | | bug:21866529 (cherry picked from commit 3c4ab80c102ff1bfc0e74d4abddbf5454bf4008d) Change-Id: Ibdc0d4a9730bfc6e7307282276f084dae5ac55c1
* Run a simplification pass before code generation.Nicolas Geoffray2015-06-221-0/+5
| | | | | | | | | | | | The code generators assume things that only the instruction simplier ensures. So it has to be run last in case previous optimiziations broke those assumptions. bug:21865464 (cherry picked from commit b2bdfce7f805b00668a2521b1c939a0aafb2be49) Change-Id: Ibf4384a911e400eb7586bbf6b4edd6351034cbd8
* Merge "Bailout from compilation if an invoke is malformed." into mnc-devNicolas Geoffray2015-06-222-10/+35
|\
| * Bailout from compilation if an invoke is malformed.Nicolas Geoffray2015-06-222-10/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | Because the verifier does not check trivially dead instructions, the compilers must prepare for bogus instructions. This change fixes the case the arguments for an invoke do not match the formal parameters. bug:21865459 (cherry picked from commit 2e33525bd4eb892246b4c244c6d4ebf6c6d07501) Change-Id: I392f86eafefde28263fe35a31f17b398ff8dfc24
* | Merge "Fix wrong DCHECK in bounds check elimination." into mnc-devNicolas Geoffray2015-06-221-1/+3
|\ \
| * | Fix wrong DCHECK in bounds check elimination.Nicolas Geoffray2015-06-221-1/+3
| |/ | | | | | | | | | | | | | | | | | | | | | | The lower range of an array length instruction can be changed by other instructions than HBoundsCheck, like HNewArray. bug:21862741 (cherry picked from commit 8d82a0c2b2b12f259ccb357d3b1e699c68ad0400) Change-Id: I1bb1a4f4c6673509dd3fb5184c32992bed876250
* | Fix a bug in optimizing when the null constant has been DCE.Nicolas Geoffray2015-06-222-2/+5
|/ | | | | | | | | | | | | | If it has been DCE, we should create a new one, instead of using the old one. Also move the first DCE to a place where it could actually be useful. bug:21870788 (cherry picked from commit 18e6873c469b48aaed22148451523479eece98e3) Change-Id: I3b3ab2dafe8ce5fb60868fd1a6ef0eeefe666e0c
* Fix String Change baseline compiler errors.Nicolas Geoffray2015-06-221-2/+3
| | | | | | | | | | | | | The String Change adds multiple move results if the uninitialized string is in multiple registers. This adds StoreLocals on the same instruction, which isn't allowed. Now, a LoadLocal is added for each extra move needed. bug:21902634 (cherry picked from commit aa919207d2fb63af11d72d3b7cdbc435769565af) Change-Id: I057d14cdac437d06eec20caaddd430c304e58196
* Use signed encoding when using relative CFI addresses.David Srbecky2015-06-201-2/+12
| | | | | | | | | | This is required for gdb to work. libunwind works with either encoding. (cherry picked from commit 17065880693d1b15ffeb60b9955a2d092839977f) Bug: 21924613 Change-Id: I4e4f1cf9c65d48fa885a5993eeeed0253a3f2579
* Merge "ART: Fix BCE lint issue" into mnc-devMingyao Yang2015-06-191-2/+2
|\
generated by cgit v1.1 at 2025-01-08 04:06:59 +0000