| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Before this change, cpplint would erroneously recognize
`return_type(arg_type)' within
`std::function<return_type(arg_type)>' as a C-style cast.
Change-Id: I41933fbdbb835e2950304de29edd33b16939708d
|
|
|
|
|
|
|
|
| |
* This is how it is done in other scripts in the AOSP tree, as
'/usr/bin/python' may be python3 on some distros, which isn't
supported yet.
Change-Id: I0d9857fc6a122f505953fddcd6244dad75b1838a
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to update cpplint to handle const auto.
Fixed a few cpplint errors that were being missed before.
Replaced most of the TODO c++0x with ranged based loops. Loops which
do not have a descriptive container name have a concrete type instead
of auto.
Change-Id: Id7cc0f27030f56057c544e94277300b3f298c9c5
|
|
|
|
|
|
| |
The upstream cpplint.py already made this change.
Change-Id: I9614d51080557eab6730cffd476e01e7872729d0
|
|
|
|
| |
Change-Id: I1efdb07a948a2af49db1a9d21ccab16dacc03a54
|
|
|
|
| |
Change-Id: Ifc678d59a8bed24ffddde5a0e543620b17b0aba9
|
|
|
|
| |
Change-Id: Id7735be1d75bc315733b1773fba45c1deb8ace43
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handy if you have an ANR that's locking related. Quick tour:
at org.apache.harmony.dalvik.NativeTestTarget.emptyJniStaticSynchronizedMethod0(Native method)
- locked <0x60135aa8> (a java.lang.Class<org.apache.harmony.dalvik.NativeTestTarget>)
at java.lang.reflect.Method.invoke(Native method)
at C.whileTrue(Main.java:63)
at C.synchronizedOnClassString(Main.java:56)
- locked <0x60002a70> (a java.lang.Class<java.lang.String>)
at C.nestedSynchronizationWithTryCatch(Main.java:44)
- locked <0x61336b90> (a java.lang.String)
- locked <0x61336bd0> (a java.lang.String)
at C.nestedSynchronization(Main.java:35)
- locked <0x61336b18> (a java.lang.String)
- locked <0x61336b50> (a java.lang.String)
at C.synchronizedOnClassC(Main.java:30)
- locked <0x613366f8> (a java.lang.Class<C>)
at C.noLocks(Main.java:27)
at C.<clinit>(Main.java:24)
- locked <0x613366f8> (a java.lang.Class<C>)
at Main.main(Main.java:19)
A non-static synchronized native method works too:
at org.apache.harmony.dalvik.NativeTestTarget.emptyJniSynchronizedMethod0(Native method)
- locked <0x613371a8> (a org.apache.harmony.dalvik.NativeTestTarget)
...
Note that most stack traces don't look any different; the above is a
pathological example that exercises different kinds of locking. Testing
with system_server shows most threads don't hold any locks.
Future work (marked by TODO) is that explicit JNI MonitorEnter calls in
native code aren't shown.
Change-Id: I2747f5cddb4ef64b1935736f084a68fe8e4005e9
|
|
|
|
|
|
| |
From https://code.google.com/p/google-styleguide/source/browse/trunk#trunk%2Fcpplint .
Change-Id: Ie9c0efe36c9af5c1fead502ae673ca6693f3cf7b
|
|
|
|
|
|
| |
This is obsolete historical cruft.
Change-Id: I140a93ac04f5be0034812f90204e6f9ae36d2d5f
|
|
Imported without change from http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py
Will start making local changes to cpplint.py in followup changes.
Change-Id: I0fda185f4a9f96815739db8f862cf8537402bf3b
|