From c7dd295a4e0cc1d15c0c96088e55a85389bade74 Mon Sep 17 00:00:00 2001 From: Ian Rogers Date: Tue, 21 Oct 2014 23:31:19 -0700 Subject: Tidy up logging. Move gVerboseMethods to CompilerOptions. Now "--verbose-methods=" option to dex2oat rather than runtime argument "-verbose-methods:". Move ToStr and Dumpable out of logging.h, move LogMessageData into logging.cc except for a forward declaration. Remove ConstDumpable as Dump methods are all const (and make this so if not currently true). Make LogSeverity an enum and improve compile time assertions and type checking. Remove log_severity.h that's only used in logging.h. With system headers gone from logging.h, go add to .cc files missing system header includes. Also, make operator new in ValueObject private for compile time instantiation checking. Change-Id: I3228f614500ccc9b14b49c72b9821c8b0db3d641 --- disassembler/disassembler_arm.cc | 1 + disassembler/disassembler_mips.cc | 1 + disassembler/disassembler_x86.cc | 1 + 3 files changed, 3 insertions(+) (limited to 'disassembler') diff --git a/disassembler/disassembler_arm.cc b/disassembler/disassembler_arm.cc index ac883fe..9caae9c 100644 --- a/disassembler/disassembler_arm.cc +++ b/disassembler/disassembler_arm.cc @@ -19,6 +19,7 @@ #include #include +#include #include "base/logging.h" #include "base/stringprintf.h" diff --git a/disassembler/disassembler_mips.cc b/disassembler/disassembler_mips.cc index bd5fac7..c06492a 100644 --- a/disassembler/disassembler_mips.cc +++ b/disassembler/disassembler_mips.cc @@ -17,6 +17,7 @@ #include "disassembler_mips.h" #include +#include #include "base/logging.h" #include "base/stringprintf.h" diff --git a/disassembler/disassembler_x86.cc b/disassembler/disassembler_x86.cc index 63a74c7..ce14520 100644 --- a/disassembler/disassembler_x86.cc +++ b/disassembler/disassembler_x86.cc @@ -17,6 +17,7 @@ #include "disassembler_x86.h" #include +#include #include "base/logging.h" #include "base/stringprintf.h" -- cgit v1.1