From 31e8925781c2302f1d1a9b39e216ba415bfe0d7e Mon Sep 17 00:00:00 2001 From: Mathieu Chartier Date: Wed, 28 Aug 2013 11:29:12 -0700 Subject: Write out image bitmap inside of image file. We now create the image bitmap when we generate the image. The image bitmap is written after the image inside of the image file. This speeds up dex2oat by making walking the image during heap creation unnecessary. This should also help memory pressure by enabling the image bitmap to be swappable. Bug: 10432288 Change-Id: Idebf459ed15edbb41a7d9b9b353934155bce2f19 --- runtime/image.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) (limited to 'runtime/image.h') diff --git a/runtime/image.h b/runtime/image.h index 35e4c5c..5119e3a 100644 --- a/runtime/image.h +++ b/runtime/image.h @@ -21,6 +21,7 @@ #include "globals.h" #include "mirror/object.h" +#include "utils.h" namespace art { @@ -30,6 +31,9 @@ class PACKED(4) ImageHeader { ImageHeader() {} ImageHeader(uint32_t image_begin, + uint32_t image_size_, + uint32_t image_bitmap_offset, + uint32_t image_bitmap_size, uint32_t image_roots, uint32_t oat_checksum, uint32_t oat_file_begin, @@ -56,6 +60,18 @@ class PACKED(4) ImageHeader { return reinterpret_cast(image_begin_); } + size_t GetImageSize() const { + return static_cast(image_size_); + } + + size_t GetImageBitmapOffset() const { + return image_bitmap_offset_; + } + + size_t GetImageBitmapSize() const { + return image_bitmap_size_; + } + uint32_t GetOatChecksum() const { return oat_checksum_; } @@ -80,6 +96,10 @@ class PACKED(4) ImageHeader { return reinterpret_cast(oat_file_end_); } + size_t GetBitmapOffset() const { + return RoundUp(image_size_, kPageSize); + } + enum ImageRoot { kResolutionMethod, kCalleeSaveMethod, @@ -106,6 +126,15 @@ class PACKED(4) ImageHeader { // Required base address for mapping the image. uint32_t image_begin_; + // Image size, not page aligned. + uint32_t image_size_; + + // Image bitmap offset in the file. + uint32_t image_bitmap_offset_; + + // Size of the image bitmap. + uint32_t image_bitmap_size_; + // Checksum of the oat file we link to for load time sanity check. uint32_t oat_checksum_; -- cgit v1.1