From fc0e94bed3f88ed7e50854fd8dfaf5dcb345250f Mon Sep 17 00:00:00 2001 From: Ian Rogers Date: Mon, 23 Sep 2013 23:51:32 -0700 Subject: StringPiece clean up. Profile guided clean up. Try to avoid creating StringPieces with the contents of a dex file where the length is known. Try to avoid RegTypeCache::FromDescriptor when there's a class available. Make ConstantType::ConstantValue inlinable. Saving of about 50ms from a 2 threaded ThinkFree compile on host. Change-Id: I47a12c3c76f46e2c9805be1c3a3e3870fe1f5d85 --- runtime/jdwp/jdwp_handler.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'runtime/jdwp') diff --git a/runtime/jdwp/jdwp_handler.cc b/runtime/jdwp/jdwp_handler.cc index a2efc48..523d892 100644 --- a/runtime/jdwp/jdwp_handler.cc +++ b/runtime/jdwp/jdwp_handler.cc @@ -47,7 +47,7 @@ std::string DescribeMethod(const MethodId& method_id) { std::string DescribeRefTypeId(const RefTypeId& ref_type_id) { std::string signature("unknown"); - Dbg::GetSignature(ref_type_id, signature); + Dbg::GetSignature(ref_type_id, &signature); return StringPrintf("%#llx (%s)", ref_type_id, signature.c_str()); } @@ -547,7 +547,7 @@ static JdwpError RT_Signature(JdwpState*, Request& request, ExpandBuf* pReply, b RefTypeId refTypeId = request.ReadRefTypeId(); std::string signature; - JdwpError status = Dbg::GetSignature(refTypeId, signature); + JdwpError status = Dbg::GetSignature(refTypeId, &signature); if (status != ERR_NONE) { return status; } -- cgit v1.1