summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Salyzyn <salyzyn@google.com>2015-04-29 07:21:36 -0700
committerMark Salyzyn <salyzyn@google.com>2015-04-30 14:00:09 -0700
commit62075bcc91d60f5269ed6f5b5303662b556a86c4 (patch)
treea17490e90362d1ee846db256034d9755ab2b0018
parent126b5efa9d2fa0956a12a66305d7a4dac7feb4f9 (diff)
downloadbionic-62075bcc91d60f5269ed6f5b5303662b556a86c4.zip
bionic-62075bcc91d60f5269ed6f5b5303662b556a86c4.tar.gz
bionic-62075bcc91d60f5269ed6f5b5303662b556a86c4.tar.bz2
bionic: fortify comments in _system_properties.h
(Cherry pick from commit c3f4c964a3326ba81e1d61ebc47980f787dfcf24) Change-Id: I2ef8fb7ae5ae03d5d2a50b5a417d585710099760
-rw-r--r--libc/include/sys/_system_properties.h14
1 files changed, 10 insertions, 4 deletions
diff --git a/libc/include/sys/_system_properties.h b/libc/include/sys/_system_properties.h
index c200295..8086020 100644
--- a/libc/include/sys/_system_properties.h
+++ b/libc/include/sys/_system_properties.h
@@ -104,13 +104,19 @@ int __system_property_area_init();
** objects will have seen __system_property_serial values change.
** But also aids the converse, as changes in the global serial can
** also be used to predict if a failed __system_property_find
-** could in-turn now find an new object; thus preventing the
+** could in-turn now find a new object; thus preventing the
** cycles of effort to poll __system_property_find.
**
-** Called at the beginning of a cache cycle to signal _any_ possible
-** changes have occurred since last. If there is, check each individual
+** Typically called at beginning of a cache cycle to signal if _any_ possible
+** changes have occurred since last. If there is, one may check each individual
** __system_property_serial to confirm dirty, or __system_property_find
-** to check if the property now exists.
+** to check if the property now exists. If a call to __system_property_add
+** or __system_property_update has completed between two calls to
+** __system_property_area_serial then the second call will return a larger
+** value than the first call. Beware of race conditions as changes to the
+** properties are not atomic, the main value of this call is to determine
+** whether the expensive __system_property_find is worth retrying to see if
+** a property now exists.
**
** Returns the serial number on success, -1 on error.
*/