summaryrefslogtreecommitdiffstats
path: root/libc/arch-mips/syscalls/setfsgid.S
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2014-09-08 15:25:01 -0700
committerElliott Hughes <enh@google.com>2014-09-08 15:36:21 -0700
commit7efad83d430f4d824f2aaa75edea5106f6ff8aae (patch)
tree5bc18249730f5d714eb12b877db4a601ed96fefe /libc/arch-mips/syscalls/setfsgid.S
parentc8f6b82f87d9e4ea385ce6d634220b369b76845a (diff)
downloadbionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.zip
bionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.tar.gz
bionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.tar.bz2
Ensure __set_errno is still visible on LP32.
The use of the .hidden directive to avoid going via the PLT for __set_errno had the side-effect of actually making __set_errno hidden (which is odd because assembler directives don't usually affect symbols defined in a different file --- you can't even create a weak reference to a symbol that's defined in a different file). This change switches the system call stubs over to a new always-hidden __set_errno_internal and has a visible __set_errno on LP32 just for binary compatibility with old NDK apps. Bug: 17423135 Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b
Diffstat (limited to 'libc/arch-mips/syscalls/setfsgid.S')
-rw-r--r--libc/arch-mips/syscalls/setfsgid.S4
1 files changed, 1 insertions, 3 deletions
diff --git a/libc/arch-mips/syscalls/setfsgid.S b/libc/arch-mips/syscalls/setfsgid.S
index 81d33d0..158d2c0 100644
--- a/libc/arch-mips/syscalls/setfsgid.S
+++ b/libc/arch-mips/syscalls/setfsgid.S
@@ -2,8 +2,6 @@
#include <private/bionic_asm.h>
- .hidden __set_errno
-
ENTRY(setfsgid)
.set noreorder
.cpload t9
@@ -14,7 +12,7 @@ ENTRY(setfsgid)
j ra
nop
1:
- la t9,__set_errno
+ la t9,__set_errno_internal
j t9
nop
.set reorder