diff options
| author | Elliott Hughes <enh@google.com> | 2014-09-08 15:25:01 -0700 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2014-09-08 15:36:21 -0700 |
| commit | 7efad83d430f4d824f2aaa75edea5106f6ff8aae (patch) | |
| tree | 5bc18249730f5d714eb12b877db4a601ed96fefe /libc/arch-x86_64/syscalls/read.S | |
| parent | c8f6b82f87d9e4ea385ce6d634220b369b76845a (diff) | |
| download | bionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.zip bionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.tar.gz bionic-7efad83d430f4d824f2aaa75edea5106f6ff8aae.tar.bz2 | |
Ensure __set_errno is still visible on LP32.
The use of the .hidden directive to avoid going via the PLT for
__set_errno had the side-effect of actually making __set_errno
hidden (which is odd because assembler directives don't usually
affect symbols defined in a different file --- you can't even
create a weak reference to a symbol that's defined in a different
file).
This change switches the system call stubs over to a new always-hidden
__set_errno_internal and has a visible __set_errno on LP32 just for
binary compatibility with old NDK apps.
Bug: 17423135
Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b
Diffstat (limited to 'libc/arch-x86_64/syscalls/read.S')
| -rw-r--r-- | libc/arch-x86_64/syscalls/read.S | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/libc/arch-x86_64/syscalls/read.S b/libc/arch-x86_64/syscalls/read.S index 3f2862e..df70e7f 100644 --- a/libc/arch-x86_64/syscalls/read.S +++ b/libc/arch-x86_64/syscalls/read.S @@ -2,8 +2,6 @@ #include <private/bionic_asm.h> - .hidden __set_errno - ENTRY(read) movl $__NR_read, %eax syscall @@ -11,7 +9,7 @@ ENTRY(read) jb 1f negl %eax movl %eax, %edi - call __set_errno + call __set_errno_internal 1: ret END(read) |