diff options
| author | Elliott Hughes <enh@google.com> | 2013-10-09 15:50:50 -0700 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2013-10-09 16:00:17 -0700 |
| commit | eb847bc8666842a3cfc9c06e8458ad1abebebaf0 (patch) | |
| tree | 15e070fb706ba7599d5f402a8f934a7399541a6a /libc/stdlib | |
| parent | 0c17099a71cb5d1b36b7aab66fd7341b3fc9106d (diff) | |
| download | bionic-eb847bc8666842a3cfc9c06e8458ad1abebebaf0.zip bionic-eb847bc8666842a3cfc9c06e8458ad1abebebaf0.tar.gz bionic-eb847bc8666842a3cfc9c06e8458ad1abebebaf0.tar.bz2 | |
Fix x86_64 build, clean up intermediate libraries.
The x86_64 build was failing because clone.S had a call to __thread_entry which
was being added to a different intermediate .a on the way to making libc.so,
and the linker couldn't guarantee statically that such a relocation would be
possible.
ld: error: out/target/product/generic_x86_64/obj/STATIC_LIBRARIES/libc_common_intermediates/libc_common.a(clone.o): requires dynamic R_X86_64_PC32 reloc against '__thread_entry' which may overflow at runtime; recompile with -fPIC
This patch addresses that by ensuring that the caller and callee end up in the
same intermediate .a. While I'm here, I've tried to clean up some of the mess
that led to this situation too. In particular, this removes libc/private/ from
the default include path (except for the DNS code), and splits out the DNS
code into its own library (since it's a weird special case of upstream NetBSD
code that's diverged so heavily it's unlikely ever to get back in sync).
There's more cleanup of the DNS situation possible, but this is definitely a
step in the right direction, and it's more than enough to get x86_64 building
cleanly.
Change-Id: I00425a7245b7a2573df16cc38798187d0729e7c4
Diffstat (limited to 'libc/stdlib')
| -rw-r--r-- | libc/stdlib/atexit.c | 2 | ||||
| -rw-r--r-- | libc/stdlib/ctype_private.h | 7 | ||||
| -rw-r--r-- | libc/stdlib/exit.c | 2 |
3 files changed, 9 insertions, 2 deletions
diff --git a/libc/stdlib/atexit.c b/libc/stdlib/atexit.c index 8f5bd2d..4e14434 100644 --- a/libc/stdlib/atexit.c +++ b/libc/stdlib/atexit.c @@ -35,7 +35,7 @@ #include <string.h> #include <unistd.h> #include "atexit.h" -#include "thread_private.h" +#include "private/thread_private.h" int __atexit_invalid = 1; struct atexit *__atexit; diff --git a/libc/stdlib/ctype_private.h b/libc/stdlib/ctype_private.h new file mode 100644 index 0000000..39cc792 --- /dev/null +++ b/libc/stdlib/ctype_private.h @@ -0,0 +1,7 @@ +/* $OpenBSD: ctype_private.h,v 1.1 2005/08/08 05:53:00 espie Exp $ */ +/* Written by Marc Espie, public domain */ +#define CTYPE_NUM_CHARS 256 +extern const char _C_ctype_[]; +extern const short _C_toupper_[]; +extern const short _C_tolower_[]; + diff --git a/libc/stdlib/exit.c b/libc/stdlib/exit.c index 83fe3d2..923e42e 100644 --- a/libc/stdlib/exit.c +++ b/libc/stdlib/exit.c @@ -33,7 +33,7 @@ #include <stdlib.h> #include <unistd.h> #include "atexit.h" -#include "thread_private.h" +#include "private/thread_private.h" /* * This variable is zero until a process has created a thread. |