summaryrefslogtreecommitdiffstats
path: root/linker/dlfcn.cpp
diff options
context:
space:
mode:
authorDmitriy Ivanov <dimitry@google.com>2015-06-29 14:48:25 -0700
committerDmitriy Ivanov <dimitry@google.com>2015-06-29 14:48:25 -0700
commitf7d5bf334dc4bc5b7399d4c8268e1b0bf676548f (patch)
tree6ceb11112515fce7d625d8c6d4715bee2f1b05eb /linker/dlfcn.cpp
parent06700b2b5e92a365505b15d0d05e2d5b0706c511 (diff)
downloadbionic-f7d5bf334dc4bc5b7399d4c8268e1b0bf676548f.zip
bionic-f7d5bf334dc4bc5b7399d4c8268e1b0bf676548f.tar.gz
bionic-f7d5bf334dc4bc5b7399d4c8268e1b0bf676548f.tar.bz2
Lock on dl_interate_phdr
There is possibility of someone dlclosing a library while dl_iterate_phdr in progress which can lead to dl_iterate_phdr calling callback with invalid address if it was unmapped by dlclose. Bug: http://b/22047255 Change-Id: I3fc0d9fd2c51fb36fd34cb035f37271fa893a7be
Diffstat (limited to 'linker/dlfcn.cpp')
-rw-r--r--linker/dlfcn.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/linker/dlfcn.cpp b/linker/dlfcn.cpp
index a70abf5..ef454ab 100644
--- a/linker/dlfcn.cpp
+++ b/linker/dlfcn.cpp
@@ -158,6 +158,11 @@ int dlclose(void* handle) {
return 0;
}
+int dl_iterate_phdr(int (*cb)(dl_phdr_info* info, size_t size, void* data), void* data) {
+ ScopedPthreadMutexLocker locker(&g_dl_mutex);
+ return do_dl_iterate_phdr(cb, data);
+}
+
void android_set_application_target_sdk_version(uint32_t target) {
// lock to avoid modification in the middle of dlopen.
ScopedPthreadMutexLocker locker(&g_dl_mutex);