diff options
| author | Robin Burchell <robin.burchell@collabora.co.uk> | 2012-07-05 09:23:19 +0200 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2012-07-16 10:03:35 -0700 |
| commit | 8211bc6325ef61f2fe2021fac9e0f4219abaccf2 (patch) | |
| tree | 6be741ab104858dba834bc84ecb75fabec4ddfab /linker | |
| parent | decb531ce29e0472d5d3117c4bfda674f374a771 (diff) | |
| download | bionic-8211bc6325ef61f2fe2021fac9e0f4219abaccf2.zip bionic-8211bc6325ef61f2fe2021fac9e0f4219abaccf2.tar.gz bionic-8211bc6325ef61f2fe2021fac9e0f4219abaccf2.tar.bz2 | |
linker: cleanup of undefined state handling, which is really dead code
Given that _elf_lookup (and thus, _do_lookup) cannot possibly return an
undefined symbol (due to the check for SHN_UNDEF in _elf_lookup), there's
no need for spurious checks for SHN_UNDEF on its return value.
Conflicts:
linker/linker.c
Change-Id: Ic73cf439924b45f72d4d9ba3f64a888c96cbbd9b
Diffstat (limited to 'linker')
| -rw-r--r-- | linker/linker.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/linker/linker.c b/linker/linker.c index 4bf5dc9..2a7ccd5 100644 --- a/linker/linker.c +++ b/linker/linker.c @@ -462,7 +462,7 @@ soinfo_do_lookup(soinfo *si, const char *name, Elf32_Addr *offset) DEBUG("%5d %s: looking up %s in %s\n", pid, si->name, name, lsi->name); s = soinfo_elf_lookup(lsi, elf_hash, name); - if ((s != NULL) && (s->st_shndx != SHN_UNDEF)) + if (s != NULL) goto done; } } |