diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2014-08-27 13:45:37 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2014-08-27 13:45:37 -0700 |
| commit | a2c6ae6f841d088b79a2a7bbd73847b8b199a521 (patch) | |
| tree | eb4a0f2c52238e16735e90cc14fffacb87e4aa1b /tests/dlext_test.cpp | |
| parent | 9e307af982ea9030849293b5e3307733289e3c2c (diff) | |
| download | bionic-a2c6ae6f841d088b79a2a7bbd73847b8b199a521.zip bionic-a2c6ae6f841d088b79a2a7bbd73847b8b199a521.tar.gz bionic-a2c6ae6f841d088b79a2a7bbd73847b8b199a521.tar.bz2 | |
Add missing type casts before comparison.
BUG: 17300548
Change-Id: Ice9868f36c8fa8cd40bb13741b0e33c8f8d354fd
Diffstat (limited to 'tests/dlext_test.cpp')
| -rw-r--r-- | tests/dlext_test.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/tests/dlext_test.cpp b/tests/dlext_test.cpp index da63046..9a96b67 100644 --- a/tests/dlext_test.cpp +++ b/tests/dlext_test.cpp @@ -117,7 +117,7 @@ TEST_F(DlExtTest, Reserved) { ASSERT_DL_NOTNULL(handle_); fn f = reinterpret_cast<fn>(dlsym(handle_, "getRandomNumber")); ASSERT_DL_NOTNULL(f); - EXPECT_GE(f, start); + EXPECT_GE(reinterpret_cast<void*>(f), start); EXPECT_LT(reinterpret_cast<void*>(f), reinterpret_cast<char*>(start) + LIBSIZE); EXPECT_EQ(4, f()); @@ -147,7 +147,7 @@ TEST_F(DlExtTest, ReservedHint) { ASSERT_DL_NOTNULL(handle_); fn f = reinterpret_cast<fn>(dlsym(handle_, "getRandomNumber")); ASSERT_DL_NOTNULL(f); - EXPECT_GE(f, start); + EXPECT_GE(reinterpret_cast<void*>(f), start); EXPECT_LT(reinterpret_cast<void*>(f), reinterpret_cast<char*>(start) + LIBSIZE); EXPECT_EQ(4, f()); @@ -165,8 +165,9 @@ TEST_F(DlExtTest, ReservedHintTooSmall) { ASSERT_DL_NOTNULL(handle_); fn f = reinterpret_cast<fn>(dlsym(handle_, "getRandomNumber")); ASSERT_DL_NOTNULL(f); - EXPECT_TRUE(f < start || (reinterpret_cast<void*>(f) >= - reinterpret_cast<char*>(start) + PAGE_SIZE)); + EXPECT_TRUE(reinterpret_cast<void*>(f) < start || + (reinterpret_cast<void*>(f) >= + reinterpret_cast<char*>(start) + PAGE_SIZE)); EXPECT_EQ(4, f()); } |