| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Add fchmodat(AT_SYMLINK_NOFOLLOW) and fchmod O_PATH support | Nick Kralevich | 2015-02-02 | 1 | -25/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many libc functions have an option to not follow symbolic links. This is useful to avoid security sensitive code from inadvertantly following attacker supplied symlinks and taking inappropriate action on files it shouldn't. For example, open() has O_NOFOLLOW, chown() has lchown(), stat() has lstat(), etc. There is no such equivalent function for chmod(), such as lchmod(). To address this, POSIX introduced fchmodat(AT_SYMLINK_NOFOLLOW), which is intended to provide a way to perform a chmod operation which doesn't follow symlinks. Currently, the Linux kernel doesn't implement AT_SYMLINK_NOFOLLOW. In GLIBC, attempting to use the AT_SYMLINK_NOFOLLOW flag causes fchmodat to return ENOTSUP. Details are in "man fchmodat". Bionic currently differs from GLIBC in that AT_SYMLINK_NOFOLLOW is silently ignored and treated as if the flag wasn't present. This patch provides a userspace implementation of AT_SYMLINK_NOFOLLOW for bionic. Using open(O_PATH | O_NOFOLLOW), we can provide a way to atomically change the permissions on files without worrying about race conditions. As part of this change, we add support for fchmod on O_PATH file descriptors, because it's relatively straight forward and could be useful in the future. The basic idea behind this implementation comes from https://sourceware.org/bugzilla/show_bug.cgi?id=14578 , specifically comment #10. Change-Id: I1eba0cdb2c509d9193ceecf28f13118188a3cfa7 | ||||
| * | Ensure __set_errno is still visible on LP32. | Elliott Hughes | 2014-09-08 | 1 | -3/+1 |
| | | | | | | | | | | | | | | | | | | | The use of the .hidden directive to avoid going via the PLT for __set_errno had the side-effect of actually making __set_errno hidden (which is odd because assembler directives don't usually affect symbols defined in a different file --- you can't even create a weak reference to a symbol that's defined in a different file). This change switches the system call stubs over to a new always-hidden __set_errno_internal and has a visible __set_errno on LP32 just for binary compatibility with old NDK apps. (cherry-pick of 7efad83d430f4d824f2aaa75edea5106f6ff8aae.) Bug: 17423135 Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b | ||||
| * | Make __set_errno hidden in asm. | Dan Albert | 2014-08-08 | 1 | -0/+2 |
| | | | | | | | | This fixes the build after the -Bsymbolic change. Bug: 16853291 Change-Id: I989c9fec3c32e0289ea257a3bd2b7fd2709b6ce2 | ||||
| * | Make mips/mips64 syscall stubs more like the other architectures. | Elliott Hughes | 2014-02-19 | 1 | -9/+3 |
| | | | | | Change-Id: I55f8c1a95f643a6e484f12fbcc25e2c77e55b6b8 | ||||
| * | [MIPS64] Add syscall related files | Chris Dearman | 2014-02-06 | 1 | -0/+31 |
| Change-Id: I2f5d05df0e767538a6fe467ca0a2386325f8b71f Signed-off-by: Chris Dearman <chris.dearman@imgtec.com> Signed-off-by: Raghu Gandham <raghu.gandham@imgtec.com> Signed-off-by: Duane Sand <duane.sand@imgtec.com> | |||||
 |
index : bionic.git | |
| Android's bionic |
| summaryrefslogtreecommitdiffstats |