summaryrefslogtreecommitdiffstats
path: root/libc/bionic/__strncat_chk.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Avoid confusing "read prevented write" log messages.Elliott Hughes2013-10-151-23/+20
| | | | | | Moving to a "function: message" style avoids ambiguity. Change-Id: If9d590e50265c61725d3673bd03796e65edd2d5e
* Fix x86_64 build, clean up intermediate libraries.Elliott Hughes2013-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | The x86_64 build was failing because clone.S had a call to __thread_entry which was being added to a different intermediate .a on the way to making libc.so, and the linker couldn't guarantee statically that such a relocation would be possible. ld: error: out/target/product/generic_x86_64/obj/STATIC_LIBRARIES/libc_common_intermediates/libc_common.a(clone.o): requires dynamic R_X86_64_PC32 reloc against '__thread_entry' which may overflow at runtime; recompile with -fPIC This patch addresses that by ensuring that the caller and callee end up in the same intermediate .a. While I'm here, I've tried to clean up some of the mess that led to this situation too. In particular, this removes libc/private/ from the default include path (except for the DNS code), and splits out the DNS code into its own library (since it's a weird special case of upstream NetBSD code that's diverged so heavily it's unlikely ever to get back in sync). There's more cleanup of the DNS situation possible, but this is definitely a step in the right direction, and it's more than enough to get x86_64 building cleanly. Change-Id: I00425a7245b7a2573df16cc38798187d0729e7c4
* Make error messages even better!Nick Kralevich2013-10-041-1/+1
| | | | Change-Id: I72bd1eb1d526dc59833e5bc3c636171f7f9545af
* FORTIFY_SOURCE: emphasize prevention in error messages.Nick Kralevich2013-10-041-1/+1
| | | | | | | | | | | FORTIFY_SOURCE prevents buffer overflows from occurring. However, the error message often implies that we only detect it, not prevent it. Bring more clarity to the error messages by emphasizing prevention over detection. Change-Id: I5f3e1478673bdfc589e6cc4199fce8e52e197a24
* FORTIFY_SOURCE: strcat / strncat optimizeNick Kralevich2013-05-311-18/+23
| | | | | | | | | | | | | | | | __strcat_chk and __strncat_chk are slightly inefficient, because they end up traversing over the same memory region two times. This change optimizes __strcat_chk / __strncat_chk so they only access the memory once. Although I haven't benchmarked these changes, it should improve the performance of these functions. __strlen_chk - expose this function, even if -D_FORTIFY_SOURCE isn't defined. This is needed to compile libc itself without -D_FORTIFY_SOURCE. Change-Id: Id2c70dff55a276b47c59db27a03734d659f84b74
* Clean up internal libc logging.Elliott Hughes2013-03-151-1/+1
| | | | | | | | | | | We only need one logging API, and I prefer the one that does no allocation and is thus safe to use in any context. Also use O_CLOEXEC when opening the /dev/log files. Move everything logging-related into one header file. Change-Id: Ic1e3ea8e9b910dc29df351bff6c0aa4db26fbb58
* clean up FORTIFY_SOURCE handling.Nick Kralevich2012-12-041-8/+4
| | | | | | Avoid duplicating huge chunks of code. Change-Id: Id6145cdfce781c5ffba2abaaa79681d25a7ab28f
* Move the FORTIFY_SOURCE helpers over to .cpp.Elliott Hughes2012-10-221-0/+72
Change-Id: Ib5067d51b983cac7760c975becce7fe2408ead04