From 011e111d299284b65af07add523a9dccac356244 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 8 Sep 2014 15:25:01 -0700 Subject: Ensure __set_errno is still visible on LP32. The use of the .hidden directive to avoid going via the PLT for __set_errno had the side-effect of actually making __set_errno hidden (which is odd because assembler directives don't usually affect symbols defined in a different file --- you can't even create a weak reference to a symbol that's defined in a different file). This change switches the system call stubs over to a new always-hidden __set_errno_internal and has a visible __set_errno on LP32 just for binary compatibility with old NDK apps. (cherry-pick of 7efad83d430f4d824f2aaa75edea5106f6ff8aae.) Bug: 17423135 Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b --- libc/arch-mips/syscalls/sendfile64.S | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'libc/arch-mips/syscalls/sendfile64.S') diff --git a/libc/arch-mips/syscalls/sendfile64.S b/libc/arch-mips/syscalls/sendfile64.S index 1d5c5f0..78f1908 100644 --- a/libc/arch-mips/syscalls/sendfile64.S +++ b/libc/arch-mips/syscalls/sendfile64.S @@ -2,8 +2,6 @@ #include - .hidden __set_errno - ENTRY(sendfile64) .set noreorder .cpload t9 @@ -14,7 +12,7 @@ ENTRY(sendfile64) j ra nop 1: - la t9,__set_errno + la t9,__set_errno_internal j t9 nop .set reorder -- cgit v1.1