From 7efad83d430f4d824f2aaa75edea5106f6ff8aae Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 8 Sep 2014 15:25:01 -0700 Subject: Ensure __set_errno is still visible on LP32. The use of the .hidden directive to avoid going via the PLT for __set_errno had the side-effect of actually making __set_errno hidden (which is odd because assembler directives don't usually affect symbols defined in a different file --- you can't even create a weak reference to a symbol that's defined in a different file). This change switches the system call stubs over to a new always-hidden __set_errno_internal and has a visible __set_errno on LP32 just for binary compatibility with old NDK apps. Bug: 17423135 Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b --- libc/arch-x86/syscalls/readv.S | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'libc/arch-x86/syscalls/readv.S') diff --git a/libc/arch-x86/syscalls/readv.S b/libc/arch-x86/syscalls/readv.S index a0b46b8..c18c1b1 100644 --- a/libc/arch-x86/syscalls/readv.S +++ b/libc/arch-x86/syscalls/readv.S @@ -2,8 +2,6 @@ #include - .hidden __set_errno - ENTRY(readv) pushl %ebx .cfi_def_cfa_offset 8 @@ -23,7 +21,7 @@ ENTRY(readv) jb 1f negl %eax pushl %eax - call __set_errno + call __set_errno_internal addl $4, %esp 1: popl %edx -- cgit v1.1