aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2013-01-04 10:56:02 +0100
committerSamuel Tardieu <sam@rfc1149.net>2013-01-04 10:56:02 +0100
commitb418bcc69c3353255a687e2d743b0c6448d97020 (patch)
treeda223a6478d1d554464d381edfe891fb8f24a1f9
parent07b7922a1cca9dddaae25ac4411fc60620314153 (diff)
downloadcgeo-b418bcc69c3353255a687e2d743b0c6448d97020.zip
cgeo-b418bcc69c3353255a687e2d743b0c6448d97020.tar.gz
cgeo-b418bcc69c3353255a687e2d743b0c6448d97020.tar.bz2
Add FIXME comment about a meaningless merge strategy
-rw-r--r--main/src/cgeo/geocaching/cgCache.java2
1 files changed, 2 insertions, 0 deletions
diff --git a/main/src/cgeo/geocaching/cgCache.java b/main/src/cgeo/geocaching/cgCache.java
index 7fbbf0c..0f5315e 100644
--- a/main/src/cgeo/geocaching/cgCache.java
+++ b/main/src/cgeo/geocaching/cgCache.java
@@ -273,6 +273,8 @@ public class cgCache implements ICache, IWaypoint {
if (StringUtils.isBlank(description)) {
description = other.description;
}
+ // FIXME: this makes no sense to favor this over the other. 0 should not be a special case here as it is
+ // in the range of acceptable values. This is probably the case at other places (rating, votes, etc.) too.
if (favoritePoints == 0) {
favoritePoints = other.favoritePoints;
}