performance: faster opening of lists (~20%), better scrolling

* avoid duplicate distance calculation in distance sorter
* avoid String.format() wherever possible
* avoid lookups with constant values in database
* avoid reinitializing database all the time

1 files changed, 3 insertions, 3 deletions

diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index 0b7c4c3..58c6e92 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -669,10 +669,10 @@ public class CacheDetailActivity extends AbstractActivity {
                             dist.append(" ↘");
                         }
                         if (Settings.isUseMetricUnits()) {
-                            dist.append(String.format("%.0f", (Math.abs(diff))));
+                            dist.append(Math.abs((int) diff));
                             dist.append(" m");
                         } else {
-                            dist.append(String.format("%.0f", (Math.abs(diff) * 3.2808399)));
+                            dist.append(Math.abs((int) (diff * 3.2808399)));
                             dist.append(" ft");
                         }
                     }
@@ -1421,7 +1421,7 @@ public class CacheDetailActivity extends AbstractActivity {
             }
 
             // favourite count
-            addCacheDetail(R.string.cache_favourite, String.format("%d", cache.getFavoritePoints()) + "×");
+            addCacheDetail(R.string.cache_favourite, cache.getFavoritePoints() + "×");
 
             // own rating
             if (cache.getMyVote() > 0) {