static code analysis and other fixes

* NumberParsingExceptions, NullPointerExceptions
* StringBuilder instead of StringBuffer
* access rights
* interfaces instead of classes
* ...

1 files changed, 2 insertions, 10 deletions

diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index 349a73f..1be9ed6 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -39,7 +39,6 @@ import android.app.AlertDialog;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.Intent;
-import android.content.res.Configuration;
 import android.graphics.Bitmap;
 import android.graphics.Typeface;
 import android.graphics.drawable.BitmapDrawable;
@@ -326,13 +325,6 @@ public class CacheDetailActivity extends AbstractActivity {
     }
 
     @Override
-    public void onConfigurationChanged(Configuration newConfig) {
-        super.onConfigurationChanged(newConfig);
-
-        // Maybe keyboard hidden or display orientation changed. No need for update the UI or something else.
-    }
-
-    @Override
     public void onResume() {
         super.onResume();
 
@@ -820,7 +812,7 @@ public class CacheDetailActivity extends AbstractActivity {
             new AlertDialog.Builder(this)
                     .setTitle(res.getString(R.string.addon_missing_title))
                     .setMessage(new StringBuilder(res.getString(R.string.helper_calendar_missing))
-                            .append(" ")
+                            .append(' ')
                             .append(res.getString(R.string.addon_download_prompt))
                             .toString())
                     .setPositiveButton(getString(android.R.string.yes), new DialogInterface.OnClickListener() {
@@ -2200,7 +2192,7 @@ public class CacheDetailActivity extends AbstractActivity {
             view = (ListView) getLayoutInflater().inflate(R.layout.cacheview_logs, null);
 
             // log count
-            if (cache != null && cache.getLogCounts() != null) {
+            if (cache.getLogCounts() != null) {
                 boolean showLogCounter = false;
 
                 final StringBuilder text = new StringBuilder(200);