Simplify comparison implementation

This was triggered by issue #3532. The comparator interface could return
the following facts simultaneously A == B, A == C, B < C if A could
not be compared to others.

Now we will have A placed after B and C in any case.

Also, since most comparators can compare all caches, the defalut is true
and can be overriden if needed.

1 files changed, 2 insertions, 2 deletions

diff --git a/main/src/cgeo/geocaching/sorting/TerrainComparator.java b/main/src/cgeo/geocaching/sorting/TerrainComparator.java
index be1e9bb..9bbb5f7 100644
--- a/main/src/cgeo/geocaching/sorting/TerrainComparator.java
+++ b/main/src/cgeo/geocaching/sorting/TerrainComparator.java
@@ -9,8 +9,8 @@ import cgeo.geocaching.Geocache;
 public class TerrainComparator extends AbstractCacheComparator {
 
     @Override
-    protected boolean canCompare(final Geocache cache1, final Geocache cache2) {
-        return cache1.getTerrain() != 0.0 && cache2.getTerrain() != 0.0;
+    protected boolean canCompare(final Geocache cache) {
+        return cache.getTerrain() != 0.0;
     }
 
     @Override