aboutsummaryrefslogtreecommitdiffstats
path: root/main/src/cgeo/geocaching/ui/ImagesList.java
diff options
context:
space:
mode:
Diffstat (limited to 'main/src/cgeo/geocaching/ui/ImagesList.java')
-rw-r--r--main/src/cgeo/geocaching/ui/ImagesList.java13
1 files changed, 7 insertions, 6 deletions
diff --git a/main/src/cgeo/geocaching/ui/ImagesList.java b/main/src/cgeo/geocaching/ui/ImagesList.java
index 5727971..bf53725 100644
--- a/main/src/cgeo/geocaching/ui/ImagesList.java
+++ b/main/src/cgeo/geocaching/ui/ImagesList.java
@@ -9,6 +9,7 @@ import cgeo.geocaching.utils.Log;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang3.StringUtils;
+
import rx.Subscription;
import rx.android.observables.AndroidObservable;
import rx.functions.Action0;
@@ -102,7 +103,7 @@ public class ImagesList {
final HtmlImage imgGetter = new HtmlImage(geocode, true, offline ? StoredList.STANDARD_LIST_ID : StoredList.TEMPORARY_LIST_ID, false);
for (final Image img : images) {
- final LinearLayout rowView = (LinearLayout) inflater.inflate(R.layout.cache_image_item, null);
+ final LinearLayout rowView = (LinearLayout) inflater.inflate(R.layout.cache_image_item, imagesView, false);
assert(rowView != null);
if (StringUtils.isNotBlank(img.getTitle())) {
@@ -116,7 +117,7 @@ public class ImagesList {
descView.setVisibility(View.VISIBLE);
}
- final ImageView imageView = (ImageView) inflater.inflate(R.layout.image_item, null);
+ final ImageView imageView = (ImageView) inflater.inflate(R.layout.image_item, rowView, false);
assert(imageView != null);
subscriptions.add(AndroidObservable.bindActivity(activity, imgGetter.fetchDrawable(img.getUrl())).subscribe(new Action1<BitmapDrawable>() {
@Override
@@ -141,7 +142,7 @@ public class ImagesList {
imageView.setClickable(true);
imageView.setOnClickListener(new View.OnClickListener() {
@Override
- public void onClick(View arg0) {
+ public void onClick(final View arg0) {
viewImageInStandardApp(img, image);
}
});
@@ -169,7 +170,7 @@ public class ImagesList {
imagesView.removeAllViews();
}
- public void onCreateContextMenu(ContextMenu menu, View v) {
+ public void onCreateContextMenu(final ContextMenu menu, final View v) {
assert v instanceof ImageView;
activity.getMenuInflater().inflate(R.menu.images_list_context, menu);
final Resources res = activity.getResources();
@@ -179,7 +180,7 @@ public class ImagesList {
currentImage = images.get(view.getId());
}
- public boolean onContextItemSelected(MenuItem item) {
+ public boolean onContextItemSelected(final MenuItem item) {
switch (item.getItemId()) {
case R.id.image_open_file:
viewImageInStandardApp(currentImage, currentDrawable);
@@ -221,7 +222,7 @@ public class ImagesList {
intent.setDataAndType(Uri.fromFile(saveToTemporaryJPGFile(image)), "image/jpeg");
}
activity.startActivity(intent);
- } catch (Exception e) {
+ } catch (final Exception e) {
Log.e("ImagesList.viewImageInStandardApp", e);
}
}