Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | refactoring of database access | Bananeweizen | 2012-04-23 | 1 | -2/+2 |
| | | | | | | * use only one transaction when saving a cache * rework some methods to always take a collection of objects instead of calling the database multiple times | ||||
* | Refactoring: remove isValidIndex() and most uses of hasWaypoints() | Samuel Tardieu | 2012-04-22 | 1 | -12/+6 |
| | | | | | | | | | Most of the time, a loop on cgCache#getWaypoints() follows. This method returns an empty collection, so the cgCache#hasWaypoints() test is useless. Also, checking for a valid index is useless as cgCache#getWaypoint() will return null if the index is invalid. | ||||
* | Refactoring: fix Javadoc strings and style in cgCache | Samuel Tardieu | 2012-04-22 | 1 | -65/+40 |
| | |||||
* | Refactoring: simplify redundant if statement | Samuel Tardieu | 2012-04-22 | 1 | -8/+2 |
| | |||||
* | Refactoring: simplify boolean expression | Samuel Tardieu | 2012-04-22 | 1 | -1/+1 |
| | |||||
* | Refactoring: keep GeopointParser private to its package | Samuel Tardieu | 2012-04-21 | 1 | -4/+3 |
| | | | | | | | Geopoint exposes everything GeopointParser can do. By calling a Geopoint constructor instead of a GeopointParser method returning a Geopoint, Eclipse can do more null checks for free (a constuctor can never return a null object). | ||||
* | Refactoring: cleanup control flow | Samuel Tardieu | 2012-04-20 | 1 | -9/+3 |
| | |||||
* | refactoring: renames and encapsulation | Bananeweizen | 2012-04-19 | 1 | -13/+13 |
| | |||||
* | refactoring: rest in peace, cgBase | Bananeweizen | 2012-04-18 | 1 | -2/+174 |
| | |||||
* | refactoring: remove the logging tag from settings | Bananeweizen | 2012-04-12 | 1 | -3/+3 |
| | |||||
* | fix #1394: Red Circles around Event Caches | Bananeweizen | 2012-04-12 | 1 | -2/+1 |
| | |||||
* | Small enhancements for live-map | rsudev | 2012-04-12 | 1 | -1/+1 |
| | |||||
* | Remove unused methods | Samuel Tardieu | 2012-04-11 | 1 | -4/+0 |
| | | | | Those methods have been flagged as unused by proguard. | ||||
* | Implement equals() and hashCode() for Geopoint | Samuel Tardieu | 2012-04-11 | 1 | -1/+1 |
| | |||||
* | Waypoint and caches both have coordinates, add ICoordinates interface | Samuel Tardieu | 2012-04-11 | 1 | -11/+0 |
| | | | | | Geopoint obviously implements ICoordinates. Also, getLongitude() and getLatitude() were only used in tests, remove them. | ||||
* | Merge branch 'release' into upstream | Samuel Tardieu | 2012-04-09 | 1 | -28/+17 |
|\ | |||||
| * | Work on #1367: cleanup cgCache.isEqualTo | Samuel Tardieu | 2012-04-08 | 1 | -28/+17 |
| | | | | | | | | | | | | | | - make method private - argument cannot be null, this has been checked by the caller already - do not use if (test) return true; else return false; - use StringUtils.equalsIgnoreCase() when a field could be null | ||||
* | | more unit test for cache filters | Bananeweizen | 2012-04-07 | 1 | -2/+2 |
| | | | | | | | | * also fix cache equality for caches with empty geocodes (as used in some tests) | ||||
* | | Refactoring: use IWaypoint and cgCache instead of cgCoord object | Samuel Tardieu | 2012-04-01 | 1 | -1/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the time, the cgCoord is built from an existing cache or from an existing waypoint. And most of the time, using the IWaypoint interface is fine. We can see a cache as being a waypoint as well, so by making it implement IWaypoint we can manipulate IWaypoint objects every time we were manipulating cgCoord ones without copying. After this refactoring, cgCoord was only used to hold some partial cache information. cgCache can be used instead, and cgCoord is not needed anymore. | ||||
* | | Proxy all logs through cgeo.geocaching.utils.Log | Samuel Tardieu | 2012-03-31 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | The behaviour is unchanged, but altering Settings.isDebug() to return false will prevent verbose, debug and info levels messages from being logged. Part of work on #1301. | ||||
* | | Add method to refresh cache and some cleanup | campbeb | 2012-03-24 | 1 | -1/+1 |
|/ | |||||
* | Unit test for #1268 | blafoo | 2012-03-18 | 1 | -0/+1 |
| | |||||
* | static code analysis and other fixes | Bananeweizen | 2012-03-18 | 1 | -7/+4 |
| | | | | | | | * NumberParsingExceptions, NullPointerExceptions * StringBuilder instead of StringBuffer * access rights * interfaces instead of classes * ... | ||||
* | Optimization - Avoid use of internal getters. | campbeb | 2012-03-18 | 1 | -14/+14 |
| | | | | See http://developer.android.com/guide/practices/design/performance.html#internal_get_set | ||||
* | Include found marker in merging cache data. Fixes #1203 | blafoo | 2012-03-11 | 1 | -1/+5 |
| | |||||
* | Don't delete cache from database when just editing. Code cleanup. | campbeb | 2012-03-10 | 1 | -19/+38 |
| | |||||
* | Wrong merge. Fixes #1227 | blafoo | 2012-03-09 | 1 | -1/+2 |
| | |||||
* | refactoring: remove code duplication | Bananeweizen | 2012-03-07 | 1 | -8/+2 |
| | |||||
* | Refactor so all waypoint operations are done through the Cache object. | campbeb | 2012-03-05 | 1 | -6/+81 |
| | | | | Check for editing a waypoint when adding. Save cache after waypoint operations so finalDefined is set correctly. | ||||
* | refactoring: move constants and classes to the packages they belong to | Bananeweizen | 2012-03-04 | 1 | -1/+1 |
| | |||||
* | refactoring: performance cleanups | Bananeweizen | 2012-03-03 | 1 | -4/+4 |
| | |||||
* | Displaying changed caches in the Live Map. Improves #1184 | blafoo | 2012-02-29 | 1 | -1/+8 |
| | |||||
* | Improve offline logging | campbeb | 2012-02-28 | 1 | -2/+3 |
| | | | | | - Don't mark found when logging offline - Handle data changed to show status message - Set cache logged offline | ||||
* | refactoring: move isFinalDefined to WayPoint class | Bananeweizen | 2012-02-27 | 1 | -22/+7 |
| | |||||
* | Merge pull request #1143 from rsudev/issue1059 | rsudev | 2012-02-24 | 1 | -1/+24 |
|\ | | | | | Fixes #1059 and #1040 | ||||
| * | fix parentheses in single statement if | rsudev | 2012-02-19 | 1 | -1/+2 |
| | | |||||
| * | Notify asynchronous cache changes (log offline) | rsudev | 2012-02-18 | 1 | -1/+23 |
| | | |||||
* | | Live Map optimizations | blafoo | 2012-02-23 | 1 | -0/+9 |
| | | |||||
* | | Unified methods for BASE 31 | blafoo | 2012-02-23 | 1 | -2/+2 |
|/ | |||||
* | refactoring: use underscore in symbolic constants | Bananeweizen | 2012-02-16 | 1 | -1/+1 |
| | | | * otherwise they are not readable | ||||
* | Merge pull request #1117 from rsudev/issue1040b | rsudev | 2012-02-15 | 1 | -2/+47 |
|\ | | | | | Fix #1042, waypoint types | ||||
| * | Fix #1040, waypoint types | rsudev | 2012-02-12 | 1 | -2/+47 |
| | | | | | | Additionally introduces flag for 'final defined' in cache lists | ||||
* | | fix #972: also have existing OC caches marked as reliable | Bananeweizen | 2012-02-14 | 1 | -1/+1 |
|/ | |||||
* | Changed database handling | blafoo | 2012-02-08 | 1 | -4/+6 |
| | |||||
* | fix #1071: FC with unknown container size | Bananeweizen | 2012-01-31 | 1 | -1/+9 |
| | |||||
* | fix #1030: Refreshing stored cache can make it move to default list | Bananeweizen | 2012-01-28 | 1 | -0/+6 |
| | |||||
* | Merge branch 'master' into issue#290 | Marco Jacob | 2012-01-25 | 1 | -0/+19 |
|\ | |||||
| * | hashCode() and equals() implemented for cgCache | blafoo | 2012-01-25 | 1 | -0/+19 |
| | | |||||
* | | Merge branch 'master' into issue#290 | Marco Jacob | 2012-01-23 | 1 | -0/+1 |
|\ \ | |/ | |||||
| * | refactoring: moved some classes to packages, renaming | Bananeweizen | 2012-01-22 | 1 | -0/+1 |
| | |