aboutsummaryrefslogtreecommitdiffstats
path: root/main/src/cgeo/geocaching/cgCache.java
Commit message (Collapse)AuthorAgeFilesLines
* refactoring of database accessBananeweizen2012-04-231-2/+2
| | | | | | * use only one transaction when saving a cache * rework some methods to always take a collection of objects instead of calling the database multiple times
* Refactoring: remove isValidIndex() and most uses of hasWaypoints()Samuel Tardieu2012-04-221-12/+6
| | | | | | | | | Most of the time, a loop on cgCache#getWaypoints() follows. This method returns an empty collection, so the cgCache#hasWaypoints() test is useless. Also, checking for a valid index is useless as cgCache#getWaypoint() will return null if the index is invalid.
* Refactoring: fix Javadoc strings and style in cgCacheSamuel Tardieu2012-04-221-65/+40
|
* Refactoring: simplify redundant if statementSamuel Tardieu2012-04-221-8/+2
|
* Refactoring: simplify boolean expressionSamuel Tardieu2012-04-221-1/+1
|
* Refactoring: keep GeopointParser private to its packageSamuel Tardieu2012-04-211-4/+3
| | | | | | | Geopoint exposes everything GeopointParser can do. By calling a Geopoint constructor instead of a GeopointParser method returning a Geopoint, Eclipse can do more null checks for free (a constuctor can never return a null object).
* Refactoring: cleanup control flowSamuel Tardieu2012-04-201-9/+3
|
* refactoring: renames and encapsulationBananeweizen2012-04-191-13/+13
|
* refactoring: rest in peace, cgBaseBananeweizen2012-04-181-2/+174
|
* refactoring: remove the logging tag from settingsBananeweizen2012-04-121-3/+3
|
* fix #1394: Red Circles around Event CachesBananeweizen2012-04-121-2/+1
|
* Small enhancements for live-maprsudev2012-04-121-1/+1
|
* Remove unused methodsSamuel Tardieu2012-04-111-4/+0
| | | | Those methods have been flagged as unused by proguard.
* Implement equals() and hashCode() for GeopointSamuel Tardieu2012-04-111-1/+1
|
* Waypoint and caches both have coordinates, add ICoordinates interfaceSamuel Tardieu2012-04-111-11/+0
| | | | | Geopoint obviously implements ICoordinates. Also, getLongitude() and getLatitude() were only used in tests, remove them.
* Merge branch 'release' into upstreamSamuel Tardieu2012-04-091-28/+17
|\
| * Work on #1367: cleanup cgCache.isEqualToSamuel Tardieu2012-04-081-28/+17
| | | | | | | | | | | | | | - make method private - argument cannot be null, this has been checked by the caller already - do not use if (test) return true; else return false; - use StringUtils.equalsIgnoreCase() when a field could be null
* | more unit test for cache filtersBananeweizen2012-04-071-2/+2
| | | | | | | | * also fix cache equality for caches with empty geocodes (as used in some tests)
* | Refactoring: use IWaypoint and cgCache instead of cgCoord objectSamuel Tardieu2012-04-011-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the time, the cgCoord is built from an existing cache or from an existing waypoint. And most of the time, using the IWaypoint interface is fine. We can see a cache as being a waypoint as well, so by making it implement IWaypoint we can manipulate IWaypoint objects every time we were manipulating cgCoord ones without copying. After this refactoring, cgCoord was only used to hold some partial cache information. cgCache can be used instead, and cgCoord is not needed anymore.
* | Proxy all logs through cgeo.geocaching.utils.LogSamuel Tardieu2012-03-311-1/+1
| | | | | | | | | | | | | | | | The behaviour is unchanged, but altering Settings.isDebug() to return false will prevent verbose, debug and info levels messages from being logged. Part of work on #1301.
* | Add method to refresh cache and some cleanupcampbeb2012-03-241-1/+1
|/
* Unit test for #1268blafoo2012-03-181-0/+1
|
* static code analysis and other fixesBananeweizen2012-03-181-7/+4
| | | | | | | * NumberParsingExceptions, NullPointerExceptions * StringBuilder instead of StringBuffer * access rights * interfaces instead of classes * ...
* Optimization - Avoid use of internal getters.campbeb2012-03-181-14/+14
| | | | See http://developer.android.com/guide/practices/design/performance.html#internal_get_set
* Include found marker in merging cache data. Fixes #1203blafoo2012-03-111-1/+5
|
* Don't delete cache from database when just editing. Code cleanup.campbeb2012-03-101-19/+38
|
* Wrong merge. Fixes #1227blafoo2012-03-091-1/+2
|
* refactoring: remove code duplicationBananeweizen2012-03-071-8/+2
|
* Refactor so all waypoint operations are done through the Cache object.campbeb2012-03-051-6/+81
| | | | Check for editing a waypoint when adding. Save cache after waypoint operations so finalDefined is set correctly.
* refactoring: move constants and classes to the packages they belong toBananeweizen2012-03-041-1/+1
|
* refactoring: performance cleanupsBananeweizen2012-03-031-4/+4
|
* Displaying changed caches in the Live Map. Improves #1184blafoo2012-02-291-1/+8
|
* Improve offline loggingcampbeb2012-02-281-2/+3
| | | | | - Don't mark found when logging offline - Handle data changed to show status message - Set cache logged offline
* refactoring: move isFinalDefined to WayPoint classBananeweizen2012-02-271-22/+7
|
* Merge pull request #1143 from rsudev/issue1059rsudev2012-02-241-1/+24
|\ | | | | Fixes #1059 and #1040
| * fix parentheses in single statement ifrsudev2012-02-191-1/+2
| |
| * Notify asynchronous cache changes (log offline)rsudev2012-02-181-1/+23
| |
* | Live Map optimizationsblafoo2012-02-231-0/+9
| |
* | Unified methods for BASE 31blafoo2012-02-231-2/+2
|/
* refactoring: use underscore in symbolic constantsBananeweizen2012-02-161-1/+1
| | | * otherwise they are not readable
* Merge pull request #1117 from rsudev/issue1040brsudev2012-02-151-2/+47
|\ | | | | Fix #1042, waypoint types
| * Fix #1040, waypoint typesrsudev2012-02-121-2/+47
| | | | | | Additionally introduces flag for 'final defined' in cache lists
* | fix #972: also have existing OC caches marked as reliableBananeweizen2012-02-141-1/+1
|/
* Changed database handlingblafoo2012-02-081-4/+6
|
* fix #1071: FC with unknown container sizeBananeweizen2012-01-311-1/+9
|
* fix #1030: Refreshing stored cache can make it move to default listBananeweizen2012-01-281-0/+6
|
* Merge branch 'master' into issue#290Marco Jacob2012-01-251-0/+19
|\
| * hashCode() and equals() implemented for cgCacheblafoo2012-01-251-0/+19
| |
* | Merge branch 'master' into issue#290Marco Jacob2012-01-231-0/+1
|\ \ | |/
| * refactoring: moved some classes to packages, renamingBananeweizen2012-01-221-0/+1
| |