From e8b6d9c654d12e3d520e1de5fa3f0e697317ee46 Mon Sep 17 00:00:00 2001
From: Samuel Tardieu <sam@rfc1149.net>
Date: Sun, 31 Aug 2014 22:28:19 +0200
Subject: fix #4287: GC does not allow favorite point on CITO caches

---
 main/src/cgeo/geocaching/Geocache.java                    | 2 +-
 main/src/cgeo/geocaching/connector/AbstractConnector.java | 2 +-
 main/src/cgeo/geocaching/connector/IConnector.java        | 2 +-
 main/src/cgeo/geocaching/connector/gc/GCConnector.java    | 5 +++--
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/main/src/cgeo/geocaching/Geocache.java b/main/src/cgeo/geocaching/Geocache.java
index e0daae1..d9b2856 100644
--- a/main/src/cgeo/geocaching/Geocache.java
+++ b/main/src/cgeo/geocaching/Geocache.java
@@ -536,7 +536,7 @@ public class Geocache implements ICache, IWaypoint {
     }
 
     public boolean supportsFavoritePoints() {
-        return getConnector().supportsFavoritePoints();
+        return getConnector().supportsFavoritePoints(this);
     }
 
     public boolean supportsLogging() {
diff --git a/main/src/cgeo/geocaching/connector/AbstractConnector.java b/main/src/cgeo/geocaching/connector/AbstractConnector.java
index 7e1ca13..9729e06 100644
--- a/main/src/cgeo/geocaching/connector/AbstractConnector.java
+++ b/main/src/cgeo/geocaching/connector/AbstractConnector.java
@@ -76,7 +76,7 @@ public abstract class AbstractConnector implements IConnector {
     }
 
     @Override
-    public boolean supportsFavoritePoints() {
+    public boolean supportsFavoritePoints(final Geocache cache) {
         return false;
     }
 
diff --git a/main/src/cgeo/geocaching/connector/IConnector.java b/main/src/cgeo/geocaching/connector/IConnector.java
index fbade5a..e6b6674 100644
--- a/main/src/cgeo/geocaching/connector/IConnector.java
+++ b/main/src/cgeo/geocaching/connector/IConnector.java
@@ -72,7 +72,7 @@ public interface IConnector {
      *
      * @return
      */
-    public boolean supportsFavoritePoints();
+    public boolean supportsFavoritePoints(final Geocache cache);
 
     /**
      * enable/disable logging controls in cache details
diff --git a/main/src/cgeo/geocaching/connector/gc/GCConnector.java b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
index 420fd34..50275f1 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCConnector.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
@@ -20,6 +20,7 @@ import cgeo.geocaching.connector.capability.ISearchByGeocode;
 import cgeo.geocaching.connector.capability.ISearchByKeyword;
 import cgeo.geocaching.connector.capability.ISearchByOwner;
 import cgeo.geocaching.connector.capability.ISearchByViewPort;
+import cgeo.geocaching.enumerations.CacheType;
 import cgeo.geocaching.enumerations.StatusCode;
 import cgeo.geocaching.geopoint.Geopoint;
 import cgeo.geocaching.geopoint.Viewport;
@@ -285,8 +286,8 @@ public class GCConnector extends AbstractConnector implements ISearchByGeocode,
     }
 
     @Override
-    public boolean supportsFavoritePoints() {
-        return true;
+    public boolean supportsFavoritePoints(final Geocache cache) {
+        return cache.getType() != CacheType.CITO;
     }
 
     @Override
-- 
cgit v1.1