From 46bcd8d179e95a80680e83eb43e9bf6ddfaf6f12 Mon Sep 17 00:00:00 2001 From: Bananeweizen Date: Fri, 19 Jul 2013 17:07:08 +0200 Subject: fix #3020: document request headers for caching --- main/src/cgeo/geocaching/network/Network.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'main/src') diff --git a/main/src/cgeo/geocaching/network/Network.java b/main/src/cgeo/geocaching/network/Network.java index fc11dc8..2d2ab0b 100644 --- a/main/src/cgeo/geocaching/network/Network.java +++ b/main/src/cgeo/geocaching/network/Network.java @@ -319,8 +319,9 @@ public abstract class Network { final String etag = LocalStorage.getSavedHeader(cacheFile, LocalStorage.HEADER_ETAG); if (etag != null) { + // The ETag is a more robust check than a timestamp. If we have an ETag, it is enough + // to identify the right version of the resource. return new Parameters("If-None-Match", etag); - //FIXME: This seems to be wrong. Shouldn't we check for both headers instead of returning after finding the first? } final String lastModified = LocalStorage.getSavedHeader(cacheFile, LocalStorage.HEADER_LAST_MODIFIED); -- cgit v1.1