From 7b1c980547211e9bc26f3f12e934d128b7da254f Mon Sep 17 00:00:00 2001
From: Bananeweizen <bananeweizen@gmx.de>
Date: Thu, 9 May 2013 08:17:32 +0200
Subject: refactoring: Lint cleanups

---
 main/src/cgeo/geocaching/CacheDetailActivity.java |  2 +-
 main/src/cgeo/geocaching/ui/EditNoteDialog.java   | 13 +++++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

(limited to 'main/src')

diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index fe17c06..b0bee55 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -1785,7 +1785,7 @@ public class CacheDetailActivity extends AbstractViewPagerActivity<CacheDetailAc
                                 cgData.saveCache(cache, EnumSet.of(SaveFlag.SAVE_DB));                            }
                         };
                         final FragmentManager fm = getSupportFragmentManager();
-                        final EditNoteDialog dialog = new EditNoteDialog(cache.getPersonalNote());
+                        final EditNoteDialog dialog = EditNoteDialog.newInstance(cache.getPersonalNote());
                         dialog.show(fm, "fragment_edit_note");
                     }
                 });
diff --git a/main/src/cgeo/geocaching/ui/EditNoteDialog.java b/main/src/cgeo/geocaching/ui/EditNoteDialog.java
index 23e57f2..4d3ab6f 100644
--- a/main/src/cgeo/geocaching/ui/EditNoteDialog.java
+++ b/main/src/cgeo/geocaching/ui/EditNoteDialog.java
@@ -21,6 +21,8 @@ public class EditNoteDialog extends DialogFragment implements OnEditorActionList
         void onFinishEditNoteDialog(final String inputText);
     }
 
+    public static final String ARGUMENT_INITIAL_NOTE = "initialNote";
+
     private EditText mEditText;
     private String initialNote;
 
@@ -28,8 +30,14 @@ public class EditNoteDialog extends DialogFragment implements OnEditorActionList
         // Empty constructor required for DialogFragment
     }
 
-    public EditNoteDialog(final String initialNote) {
-        this.initialNote = initialNote;
+    public static EditNoteDialog newInstance(final String initialNote) {
+        EditNoteDialog dialog = new EditNoteDialog();
+
+        Bundle arguments = new Bundle();
+        arguments.putString(EditNoteDialog.ARGUMENT_INITIAL_NOTE, initialNote);
+        dialog.setArguments(arguments);
+
+        return dialog;
     }
 
     @Override
@@ -37,6 +45,7 @@ public class EditNoteDialog extends DialogFragment implements OnEditorActionList
                              final Bundle savedInstanceState) {
         View view = inflater.inflate(R.layout.fragment_edit_note, container);
         mEditText = (EditText) view.findViewById(R.id.note);
+        initialNote = getArguments().getString(ARGUMENT_INITIAL_NOTE);
         if (initialNote != null) {
             mEditText.setText(initialNote);
             initialNote = null;
-- 
cgit v1.1