From b418bcc69c3353255a687e2d743b0c6448d97020 Mon Sep 17 00:00:00 2001 From: Samuel Tardieu Date: Fri, 4 Jan 2013 10:56:02 +0100 Subject: Add FIXME comment about a meaningless merge strategy --- main/src/cgeo/geocaching/cgCache.java | 2 ++ 1 file changed, 2 insertions(+) (limited to 'main/src') diff --git a/main/src/cgeo/geocaching/cgCache.java b/main/src/cgeo/geocaching/cgCache.java index 7fbbf0c..0f5315e 100644 --- a/main/src/cgeo/geocaching/cgCache.java +++ b/main/src/cgeo/geocaching/cgCache.java @@ -273,6 +273,8 @@ public class cgCache implements ICache, IWaypoint { if (StringUtils.isBlank(description)) { description = other.description; } + // FIXME: this makes no sense to favor this over the other. 0 should not be a special case here as it is + // in the range of acceptable values. This is probably the case at other places (rating, votes, etc.) too. if (favoritePoints == 0) { favoritePoints = other.favoritePoints; } -- cgit v1.1