From c3fac98b6f6cea86e2d023425ea11e1755eade33 Mon Sep 17 00:00:00 2001 From: Samuel Tardieu Date: Mon, 31 Mar 2014 23:48:27 +0200 Subject: Partially revert < 2.3 compatibility mode This reverts part of 46675dfdcb4c7b511b4c35e4a2242e47d4678fd4. However, since this commit did some cleanup and simplifications, we keep them. --- main/src/cgeo/geocaching/SearchResult.java | 45 +++++++++++------------------- 1 file changed, 16 insertions(+), 29 deletions(-) (limited to 'main/src') diff --git a/main/src/cgeo/geocaching/SearchResult.java b/main/src/cgeo/geocaching/SearchResult.java index a673785..12a2522 100644 --- a/main/src/cgeo/geocaching/SearchResult.java +++ b/main/src/cgeo/geocaching/SearchResult.java @@ -1,6 +1,5 @@ package cgeo.geocaching; -import android.os.Build; import cgeo.geocaching.connector.IConnector; import cgeo.geocaching.connector.gc.GCLogin; import cgeo.geocaching.enumerations.CacheType; @@ -304,35 +303,23 @@ public class SearchResult implements Parcelable { public static SearchResult parallelCombineActive(final Collection connectors, final Func1 func) { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD) { - return Observable.from(connectors).parallel(new Func1, Observable>() { - @Override - public Observable call(final Observable cObservable) { - return cObservable.flatMap(new Func1>() { - @Override - public Observable call(final C c) { - return c.isActive() ? Observable.from(func.call(c)) : Observable.empty(); - } - }); - } - }, Schedulers.io()).reduce(new SearchResult(), new Func2() { - @Override - public SearchResult call(final SearchResult searchResult, final SearchResult searchResult2) { - searchResult.addSearchResult(searchResult2); - return searchResult; - } - }).toBlockingObservable().first(); - } else { - // Use a slower, sequential version for Android < 2.3, where parallel() does not work correctly - // because of missing Java method (here, Dequeue#offerLast). - final SearchResult result = new SearchResult(); - for (final C connector : connectors) { - if (connector.isActive()) { - result.addSearchResult(func.call(connector)); - } + return Observable.from(connectors).parallel(new Func1, Observable>() { + @Override + public Observable call(final Observable cObservable) { + return cObservable.flatMap(new Func1>() { + @Override + public Observable call(final C c) { + return c.isActive() ? Observable.from(func.call(c)) : Observable.empty(); + } + }); } - return result; - } + }, Schedulers.io()).reduce(new SearchResult(), new Func2() { + @Override + public SearchResult call(final SearchResult searchResult, final SearchResult searchResult2) { + searchResult.addSearchResult(searchResult2); + return searchResult; + } + }).toBlockingObservable().first(); } } -- cgit v1.1