From 93e150e52591c7211306a40a42bc0b1ee9005dd7 Mon Sep 17 00:00:00 2001 From: Bananeweizen Date: Sun, 18 May 2014 11:15:29 +0200 Subject: multiple code cleanups * unused imports * remove author comment * restrict access * fix StaticMapsActivity code generation cycle (it should not contain references to classes which are generated by the annotation processor from itself) --- main/src/cgeo/geocaching/CacheDetailActivity.java | 2 -- main/src/cgeo/geocaching/CachePopup.java | 7 ------- main/src/cgeo/geocaching/StaticMapsActivity.java | 11 ----------- main/src/cgeo/geocaching/WaypointPopupFragment.java | 2 +- .../cgeo/geocaching/activity/AbstractActionBarActivity.java | 3 +-- .../geocaching/apps/cache/navi/AbstractStaticMapsApp.java | 8 ++++++-- 6 files changed, 8 insertions(+), 25 deletions(-) (limited to 'main') diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java index 2af9f95..e42e780 100644 --- a/main/src/cgeo/geocaching/CacheDetailActivity.java +++ b/main/src/cgeo/geocaching/CacheDetailActivity.java @@ -97,11 +97,9 @@ import android.view.Menu; import android.view.MenuItem; import android.view.View; import android.view.View.OnClickListener; -import android.view.View.OnLongClickListener; import android.view.ViewGroup; import android.view.ViewGroup.LayoutParams; import android.view.ViewParent; -import android.view.Window; import android.widget.AdapterView; import android.widget.AdapterView.OnItemClickListener; import android.widget.ArrayAdapter; diff --git a/main/src/cgeo/geocaching/CachePopup.java b/main/src/cgeo/geocaching/CachePopup.java index d886554..9036d00 100644 --- a/main/src/cgeo/geocaching/CachePopup.java +++ b/main/src/cgeo/geocaching/CachePopup.java @@ -5,10 +5,6 @@ import cgeo.geocaching.activity.ActivityMixin; import org.apache.commons.lang3.StringUtils; -import rx.functions.Action0; -import rx.functions.Action1; -import rx.schedulers.Schedulers; - import android.content.Context; import android.content.Intent; import android.os.Bundle; @@ -17,9 +13,6 @@ import android.support.v4.app.Fragment; import android.support.v4.app.FragmentTransaction; import android.view.Window; -/** - * Created by arne on 23.04.2014. - */ public class CachePopup extends AbstractActivity { protected String geocode = null; diff --git a/main/src/cgeo/geocaching/StaticMapsActivity.java b/main/src/cgeo/geocaching/StaticMapsActivity.java index 7474785..ca1f5ee 100644 --- a/main/src/cgeo/geocaching/StaticMapsActivity.java +++ b/main/src/cgeo/geocaching/StaticMapsActivity.java @@ -11,7 +11,6 @@ import org.androidannotations.annotations.OptionsMenu; import org.apache.commons.collections4.CollectionUtils; import android.app.ProgressDialog; -import android.content.Context; import android.graphics.Bitmap; import android.os.Bundle; import android.os.Handler; @@ -167,14 +166,4 @@ public class StaticMapsActivity extends AbstractActionBarActivity { showToast(res.getString(R.string.err_detail_not_load_map_static)); return false; } - - public static void startActivity(final Context activity, final String geocode, final boolean download, final Waypoint waypoint) { - /* FIXME - StaticMapsActivity_.IntentBuilder_ builder = StaticMapsActivity_.intent(activity).geocode(geocode).download(download); - if (waypoint != null) { - builder.waypointId(waypoint.getId()); - } - builder.start(); - */ - } } \ No newline at end of file diff --git a/main/src/cgeo/geocaching/WaypointPopupFragment.java b/main/src/cgeo/geocaching/WaypointPopupFragment.java index 14daada..03d95e5 100644 --- a/main/src/cgeo/geocaching/WaypointPopupFragment.java +++ b/main/src/cgeo/geocaching/WaypointPopupFragment.java @@ -48,7 +48,7 @@ public class WaypointPopupFragment extends AbstractDialogFragment { } @Override - public void onUpdateGeoData(IGeoData geo) { + protected void onUpdateGeoData(IGeoData geo) { if (geo.getCoords() != null && waypoint != null && waypoint.getCoords() != null) { waypointDistance.setText(Units.getDistanceFromKilometers(geo.getCoords().distanceTo(waypoint.getCoords()))); waypointDistance.bringToFront(); diff --git a/main/src/cgeo/geocaching/activity/AbstractActionBarActivity.java b/main/src/cgeo/geocaching/activity/AbstractActionBarActivity.java index 63100b8..b35f6e3 100644 --- a/main/src/cgeo/geocaching/activity/AbstractActionBarActivity.java +++ b/main/src/cgeo/geocaching/activity/AbstractActionBarActivity.java @@ -27,8 +27,7 @@ public class AbstractActionBarActivity extends AbstractActivity { showProgress(false); } - private void initUpAction() - { + private void initUpAction() { getSupportActionBar().setDisplayHomeAsUpEnabled(true); } } diff --git a/main/src/cgeo/geocaching/apps/cache/navi/AbstractStaticMapsApp.java b/main/src/cgeo/geocaching/apps/cache/navi/AbstractStaticMapsApp.java index c42c2a2..a2a5803 100644 --- a/main/src/cgeo/geocaching/apps/cache/navi/AbstractStaticMapsApp.java +++ b/main/src/cgeo/geocaching/apps/cache/navi/AbstractStaticMapsApp.java @@ -4,7 +4,7 @@ import cgeo.geocaching.DataStore; import cgeo.geocaching.Geocache; import cgeo.geocaching.ILogable; import cgeo.geocaching.R; -import cgeo.geocaching.StaticMapsActivity; +import cgeo.geocaching.StaticMapsActivity_; import cgeo.geocaching.StaticMapsProvider; import cgeo.geocaching.Waypoint; import cgeo.geocaching.activity.ActivityMixin; @@ -49,7 +49,11 @@ abstract class AbstractStaticMapsApp extends AbstractApp implements CacheNavigat } final String geocode = StringUtils.upperCase(logable.getGeocode()); - StaticMapsActivity.startActivity(activity, geocode, download, waypoint); + StaticMapsActivity_.IntentBuilder_ builder = StaticMapsActivity_.intent(activity).geocode(geocode).download(download); + if (waypoint != null) { + builder.waypointId(waypoint.getId()); + } + builder.start(); return true; } } -- cgit v1.1