From 53936c7ee6654a525075b03e1b4c8ddbfbcd4ef5 Mon Sep 17 00:00:00 2001
From: Gerald Barker <geraldbarker@gmail.com>
Date: Fri, 2 Sep 2011 23:19:51 +0100
Subject: First commit of Apache Commons String & Date functions and required,
 and refactor of code to use them.

---
 src/cgeo/geocaching/cgDirectionImg.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/cgeo/geocaching/cgDirectionImg.java')

diff --git a/src/cgeo/geocaching/cgDirectionImg.java b/src/cgeo/geocaching/cgDirectionImg.java
index 573cf47..33f186a 100644
--- a/src/cgeo/geocaching/cgDirectionImg.java
+++ b/src/cgeo/geocaching/cgDirectionImg.java
@@ -5,6 +5,7 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 
+import org.apache.commons.lang3.StringUtils;
 import org.apache.http.HttpEntity;
 import org.apache.http.HttpResponse;
 import org.apache.http.client.HttpClient;
@@ -20,11 +21,11 @@ public class cgDirectionImg {
 		String dirName;
 		String fileName;
 
-		if (geocode == null || geocode.length() == 0 || code == null || code.length() == 0) {
+		if (StringUtils.isBlank(geocode) || code == null || code.length() == 0) {
 			return;
 		}
 
-		if (geocode != null && geocode.length() > 0) {
+		if (StringUtils.isNotBlank(geocode)) {
 			dirName = cgSettings.getStorage() + geocode + "/";
 			fileName = cgSettings.getStorage() + geocode + "/direction.png";
 		} else {
-- 
cgit v1.1


From 4785a805cc419376e4e1adb732f728f7548cdc5c Mon Sep 17 00:00:00 2001
From: Gerald Barker <geraldbarker@gmail.com>
Date: Sat, 3 Sep 2011 15:02:21 +0100
Subject: more refctoring missed in first pass

---
 src/cgeo/geocaching/cgDirectionImg.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/cgeo/geocaching/cgDirectionImg.java')

diff --git a/src/cgeo/geocaching/cgDirectionImg.java b/src/cgeo/geocaching/cgDirectionImg.java
index 33f186a..1f513d3 100644
--- a/src/cgeo/geocaching/cgDirectionImg.java
+++ b/src/cgeo/geocaching/cgDirectionImg.java
@@ -21,7 +21,7 @@ public class cgDirectionImg {
 		String dirName;
 		String fileName;
 
-		if (StringUtils.isBlank(geocode) || code == null || code.length() == 0) {
+		if (StringUtils.isBlank(geocode) || StringUtils.isBlank(code)) {
 			return;
 		}
 
-- 
cgit v1.1