From 2dbaee334b97ea1123d8a245bc247d918ba2c6fb Mon Sep 17 00:00:00 2001 From: Samuel Tardieu Date: Sat, 21 Apr 2012 18:07:04 +0200 Subject: Refactoring: keep GeopointParser private to its package Geopoint exposes everything GeopointParser can do. By calling a Geopoint constructor instead of a GeopointParser method returning a Geopoint, Eclipse can do more null checks for free (a constuctor can never return a null object). --- tests/src/cgeo/geocaching/geopoint/GeoPointParserTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'tests/src') diff --git a/tests/src/cgeo/geocaching/geopoint/GeoPointParserTest.java b/tests/src/cgeo/geocaching/geopoint/GeoPointParserTest.java index 4e24e5a..44fbe18 100644 --- a/tests/src/cgeo/geocaching/geopoint/GeoPointParserTest.java +++ b/tests/src/cgeo/geocaching/geopoint/GeoPointParserTest.java @@ -1,7 +1,5 @@ package cgeo.geocaching.geopoint; -import cgeo.geocaching.geopoint.GeopointParser.ParseException; - import android.test.AndroidTestCase; public class GeoPointParserTest extends AndroidTestCase { @@ -27,7 +25,7 @@ public class GeoPointParserTest extends AndroidTestCase { Geopoint point = null; try { point = GeopointParser.parse("N 49° 56.031"); - } catch (ParseException e) { + } catch (Geopoint.ParseException e) { // expected } assertEquals(null, point); @@ -64,7 +62,7 @@ public class GeoPointParserTest extends AndroidTestCase { Geopoint point = null; try { point = GeopointParser.parse("N51 21.523 and some words in between, so there is no relation E07 02.680"); - } catch (ParseException e) { + } catch (Geopoint.ParseException e) { // expected } assertEquals(null, point); -- cgit v1.1