From 8ecf061ae07dd335017dbfd73727aecf61d6ea91 Mon Sep 17 00:00:00 2001 From: Bananeweizen Date: Sun, 6 May 2012 10:48:29 +0200 Subject: refactoring: remove some of the TODOs --- tests/src/cgeo/geocaching/files/GPXParserTest.java | 3 +-- tests/src/cgeo/geocaching/files/LocParserTest.java | 3 +-- .../cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) (limited to 'tests/src') diff --git a/tests/src/cgeo/geocaching/files/GPXParserTest.java b/tests/src/cgeo/geocaching/files/GPXParserTest.java index 47975c9..00e0447 100644 --- a/tests/src/cgeo/geocaching/files/GPXParserTest.java +++ b/tests/src/cgeo/geocaching/files/GPXParserTest.java @@ -193,13 +193,12 @@ public class GPXParserTest extends AbstractResourceInstrumentationTestCase { } } - // TODO: may need to sort by geocode when a test imports more than one cache return new ArrayList(caches); } public static void testParseDateWithFractionalSeconds() { // was experienced in GSAK file - String dateString = "2011-08-13T02:52:18.103Z"; + final String dateString = "2011-08-13T02:52:18.103Z"; try { GPXParser.parseDate(dateString); } catch (ParseException e) { diff --git a/tests/src/cgeo/geocaching/files/LocParserTest.java b/tests/src/cgeo/geocaching/files/LocParserTest.java index 7e7a1be..5170577 100644 --- a/tests/src/cgeo/geocaching/files/LocParserTest.java +++ b/tests/src/cgeo/geocaching/files/LocParserTest.java @@ -14,7 +14,7 @@ import java.util.List; public class LocParserTest extends AbstractResourceInstrumentationTestCase { private List readLoc(int resourceId) throws IOException, ParserException { - LocParser parser = new LocParser(1); + final LocParser parser = new LocParser(1); Collection caches = null; final InputStream instream = getResourceStream(resourceId); try { @@ -25,7 +25,6 @@ public class LocParserTest extends AbstractResourceInstrumentationTestCase { instream.close(); } - // TODO: may need to sort by geocode when a test imports more than one cache return new ArrayList(caches); } diff --git a/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java b/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java index e07a518..ab5c290 100644 --- a/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java +++ b/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java @@ -21,7 +21,6 @@ public abstract class AbstractResourceInstrumentationTestCase extends Instrument try { ins.close(); } catch (IOException e) { - // TODO Auto-generated catch block e.printStackTrace(); } return result; -- cgit v1.1