diff options
author | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-19 17:56:04 +0000 |
---|---|---|
committer | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-19 17:56:04 +0000 |
commit | 925d400db588d8650d5c3e085a581a7be4326fbd (patch) | |
tree | 446568190f0dbe31dffd2af00cf14fc63974214f /.gitignore | |
parent | ab280dcaa18c71368cd6c24797f3e85c1748449c (diff) | |
download | chromium_src-925d400db588d8650d5c3e085a581a7be4326fbd.zip chromium_src-925d400db588d8650d5c3e085a581a7be4326fbd.tar.gz chromium_src-925d400db588d8650d5c3e085a581a7be4326fbd.tar.bz2 |
Revert 89626 - Support automatic javascript test registry in gtest when creating WebUI tests.
The goal was to support something as simple as the following, where the tests in the
javascript files would be 1st class GTESTs, supporting FLAKY_, DISABLED_, etc, and
registered at linker_initialization time.
WEB_UI_BROWSER_TEST_JS(WebUIBrowserTest, TestJSPass,
FILE_PATH_LITERAL("sample_passing.js")) {
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
}
This solution ended up being fairly fragile, and I ended up with a script to parse javascript (with the help of v8_shell) and generate an includable ...-inl.h file with the following for every test in the .js file specified in the |rules| section of tools/js2webui.py
IN_PROC_BROWSER_TEST_F(WebUIBrowserTestPass, testHelper) {
AddLibrary(FilePath(FILE_PATH_LITERAL("sample_pass.js")));
ASSERT_TRUE(RunJavascriptTest("testHelper"));
}
http://www.chromium.org/Home/domui-testing
BUG=82437
R=estade@chromium.org,jhawkins@chromium.org
TEST=browser_tests --gtest_filter=WebUIBrowserTest*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89453
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89605
Review URL: http://codereview.chromium.org/7087014
TBR=scr@chromium.org
Review URL: http://codereview.chromium.org/7204022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89627 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to '.gitignore')
-rw-r--r-- | .gitignore | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -46,7 +46,6 @@ v8.log /chrome/app/theme/google_chrome /chrome/browser/autofill/internal /chrome/browser/extensions/default_extensions/chromeos -/chrome/browser/ui/webui/web_ui_browsertest-inl.h /chrome/installer/linux /chrome/installer/mac/internal /chrome/installer/mac/third_party/xz/xz |