Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/)

Reason for revert:
Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 )

Original issue's description:
> [#7] Pass gfx::Size by const ref.
>
> Any struct of size > 4 bytes should be passed by const ref.
> Passing by ref for these structs is faster than passing by value,
> especially when invoking function has multiple parameters and some
> other scenarios mentioned in the bug.
>
> BUG=159273
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426

TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=159273

Review URL: https://codereview.chromium.org/142863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 123 insertions, 127 deletions

diff --git a/.gitmodules b/.gitmodules
index f0b44be..d8fe7f0 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -6,6 +6,10 @@
 	path = build/util/support
 	url = 
 	os = ios
+[submodule "chrome/browser/resources/pdf/html_office"]
+	path = chrome/browser/resources/pdf/html_office
+	url = https://chromium.googlesource.com/chromium/html-office-public.git
+	os = all
 [submodule "chrome/installer/mac/third_party/xz/xz"]
 	path = chrome/installer/mac/third_party/xz/xz
 	url = https://chromium.googlesource.com/chromium/deps/xz.git
@@ -22,9 +26,13 @@
 	path = chrome/test/data/perf/frame_rate/content
 	url = https://chromium.googlesource.com/chromium/frame_rate/content.git
 	os = all
+[submodule "chrome/test/data/perf/third_party/octane"]
+	path = chrome/test/data/perf/third_party/octane
+	url = https://chromium.googlesource.com/external/octane-benchmark.git
+	os = all
 [submodule "chrome/tools/test/reference_build/chrome_linux"]
 	path = chrome/tools/test/reference_build/chrome_linux
-	url = https://chromium.googlesource.com/chromium/reference_builds/chrome_linux.git
+	url = https://chromium.googlesource.com/chromium/reference_builds/chrome_linux64.git
 	os = unix
 [submodule "chrome/tools/test/reference_build/chrome_mac"]
 	path = chrome/tools/test/reference_build/chrome_mac
@@ -34,94 +42,14 @@
 	path = chrome/tools/test/reference_build/chrome_win
 	url = https://chromium.googlesource.com/chromium/reference_builds/chrome_win.git
 	os = win
-[submodule "chrome_frame/tools/test/reference_build/chrome_win"]
-	path = chrome_frame/tools/test/reference_build/chrome_win
-	url = https://chromium.googlesource.com/chromium/reference_builds/chrome_win.git
-	os = win
-[submodule "content/test/data/layout_tests/LayoutTests/fast/events"]
-	path = content/test/data/layout_tests/LayoutTests/fast/events
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/fast/filesystem/resources"]
-	path = content/test/data/layout_tests/LayoutTests/fast/filesystem/resources
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/fast/js/resources"]
-	path = content/test/data/layout_tests/LayoutTests/fast/js/resources
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/fast/workers"]
-	path = content/test/data/layout_tests/LayoutTests/fast/workers
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/http/tests/appcache"]
-	path = content/test/data/layout_tests/LayoutTests/http/tests/appcache
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/http/tests/resources"]
-	path = content/test/data/layout_tests/LayoutTests/http/tests/resources
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/http/tests/websocket/tests"]
-	path = content/test/data/layout_tests/LayoutTests/http/tests/websocket/tests
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/http/tests/workers"]
-	path = content/test/data/layout_tests/LayoutTests/http/tests/workers
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/http/tests/xmlhttprequest"]
-	path = content/test/data/layout_tests/LayoutTests/http/tests/xmlhttprequest
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/media"]
-	path = content/test/data/layout_tests/LayoutTests/media
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium-win/fast/events"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium-win/fast/events
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium-win/fast/workers"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium-win/fast/workers
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium-win/http/tests/workers"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium-win/http/tests/workers
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium-win/storage/domstorage"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium-win/storage/domstorage
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium/fast/events"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium/fast/events
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/platform/chromium/fast/workers"]
-	path = content/test/data/layout_tests/LayoutTests/platform/chromium/fast/workers
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/storage/domstorage"]
-	path = content/test/data/layout_tests/LayoutTests/storage/domstorage
-	url = 
-	os = ios
-[submodule "content/test/data/layout_tests/LayoutTests/storage/indexeddb"]
-	path = content/test/data/layout_tests/LayoutTests/storage/indexeddb
-	url = 
-	os = ios
-[submodule "googleurl"]
-	path = googleurl
-	url = https://chromium.googlesource.com/external/google-url.git
+[submodule "media/cdm/ppapi/api"]
+	path = media/cdm/ppapi/api
+	url = https://chromium.googlesource.com/chromium/cdm.git
 	os = all
 [submodule "native_client"]
 	path = native_client
 	url = https://chromium.googlesource.com/native_client/src/native_client.git
 	os = all
-[submodule "sandbox/linux/seccomp-legacy"]
-	path = sandbox/linux/seccomp-legacy
-	url = https://chromium.googlesource.com/external/seccompsandbox.git
-	os = all
 [submodule "sdch/open-vcdiff"]
 	path = sdch/open-vcdiff
 	url = https://chromium.googlesource.com/external/open-vcdiff.git
@@ -138,13 +66,9 @@
 	path = testing/iossim/third_party/class-dump
 	url = https://chromium.googlesource.com/chromium/deps/class-dump.git
 	os = ios
-[submodule "third_party/GTM"]
-	path = third_party/GTM
-	url = https://chromium.googlesource.com/external/google-toolbox-for-mac.git
-	os = ios,mac
 [submodule "third_party/WebKit"]
 	path = third_party/WebKit
-	url = https://chromium.googlesource.com/external/WebKit_trimmed.git
+	url = https://chromium.googlesource.com/chromium/blink.git
 	os = all
 [submodule "third_party/android_tools"]
 	path = third_party/android_tools
@@ -152,12 +76,16 @@
 	os = android
 [submodule "third_party/angle"]
 	path = third_party/angle
-	url = https://chromium.googlesource.com/external/angleproject.git
+	url = https://chromium.googlesource.com/angle/angle.git
 	os = all
 [submodule "third_party/aosp"]
 	path = third_party/aosp
 	url = https://chromium.googlesource.com/chromium/deps/aosp.git
 	os = android
+[submodule "third_party/apache-mime4j"]
+	path = third_party/apache-mime4j
+	url = https://chromium.googlesource.com/chromium/deps/apache-mime4j.git
+	os = android
 [submodule "third_party/bidichecker"]
 	path = third_party/bidichecker
 	url = https://chromium.googlesource.com/external/bidichecker/lib.git
@@ -166,10 +94,22 @@
 	path = third_party/bison
 	url = https://chromium.googlesource.com/chromium/deps/bison.git
 	os = win
+[submodule "third_party/brotli/src"]
+	path = third_party/brotli/src
+	url = https://chromium.googlesource.com/external/font-compression-reference.git
+	os = all
 [submodule "third_party/cacheinvalidation/src"]
 	path = third_party/cacheinvalidation/src
 	url = https://chromium.googlesource.com/external/google-cache-invalidation-api/src.git
 	os = all
+[submodule "third_party/chromite"]
+	path = third_party/chromite
+	url = https://chromium.googlesource.com/chromiumos/chromite.git
+	os = unix
+[submodule "third_party/cld_2/src"]
+	path = third_party/cld_2/src
+	url = https://chromium.googlesource.com/external/cld2.git
+	os = all
 [submodule "third_party/cros_dbus_cplusplus/source"]
 	path = third_party/cros_dbus_cplusplus/source
 	url = https://chromium.googlesource.com/chromiumos/third_party/dbus-cplusplus.git
@@ -182,18 +122,34 @@
 	path = third_party/cygwin
 	url = https://chromium.googlesource.com/chromium/deps/cygwin.git
 	os = win
+[submodule "third_party/eyesfree/src/android/java/src/com/googlecode/eyesfree/braille"]
+	path = third_party/eyesfree/src/android/java/src/com/googlecode/eyesfree/braille
+	url = https://chromium.googlesource.com/external/eyes-free/braille/client/src/com/googlecode/eyesfree/braille.git
+	os = android
 [submodule "third_party/ffmpeg"]
 	path = third_party/ffmpeg
 	url = https://chromium.googlesource.com/chromium/third_party/ffmpeg.git
 	os = all
+[submodule "third_party/findbugs"]
+	path = third_party/findbugs
+	url = https://chromium.googlesource.com/chromium/deps/findbugs.git
+	os = android
 [submodule "third_party/flac"]
 	path = third_party/flac
 	url = https://chromium.googlesource.com/chromium/deps/flac.git
 	os = all
+[submodule "third_party/fontconfig/src"]
+	path = third_party/fontconfig/src
+	url = https://chromium.googlesource.com/external/fontconfig.git
+	os = unix
 [submodule "third_party/freetype"]
 	path = third_party/freetype
 	url = https://chromium.googlesource.com/chromium/src/third_party/freetype.git
 	os = android
+[submodule "third_party/freetype2/src"]
+	path = third_party/freetype2/src
+	url = https://chromium.googlesource.com/chromium/src/third_party/freetype2.git
+	os = unix
 [submodule "third_party/gnu_binutils"]
 	path = third_party/gnu_binutils
 	url = https://chromium.googlesource.com/native_client/deps/third_party/gnu_binutils.git
@@ -202,10 +158,26 @@
 	path = third_party/gold
 	url = https://chromium.googlesource.com/chromium/deps/gold.git
 	os = unix
+[submodule "third_party/google_toolbox_for_mac/src"]
+	path = third_party/google_toolbox_for_mac/src
+	url = https://chromium.googlesource.com/external/google-toolbox-for-mac.git
+	os = ios,mac
 [submodule "third_party/gperf"]
 	path = third_party/gperf
 	url = https://chromium.googlesource.com/chromium/deps/gperf.git
 	os = win
+[submodule "third_party/guava/src"]
+	path = third_party/guava/src
+	url = https://chromium.googlesource.com/external/guava-libraries.git
+	os = android
+[submodule "third_party/httpcomponents-client"]
+	path = third_party/httpcomponents-client
+	url = https://chromium.googlesource.com/chromium/deps/httpcomponents-client.git
+	os = android
+[submodule "third_party/httpcomponents-core"]
+	path = third_party/httpcomponents-core
+	url = https://chromium.googlesource.com/chromium/deps/httpcomponents-core.git
+	os = android
 [submodule "third_party/hunspell"]
 	path = third_party/hunspell
 	url = https://chromium.googlesource.com/chromium/deps/hunspell.git
@@ -218,6 +190,10 @@
 	path = third_party/icu
 	url = https://chromium.googlesource.com/chromium/deps/icu46.git
 	os = all
+[submodule "third_party/jarjar"]
+	path = third_party/jarjar
+	url = https://chromium.googlesource.com/chromium/deps/jarjar.git
+	os = android
 [submodule "third_party/jsoncpp/source/include"]
 	path = third_party/jsoncpp/source/include
 	url = https://chromium.googlesource.com/external/jsoncpp/jsoncpp/include.git
@@ -226,22 +202,42 @@
 	path = third_party/jsoncpp/source/src/lib_json
 	url = https://chromium.googlesource.com/external/jsoncpp/jsoncpp/src/lib_json.git
 	os = all
+[submodule "third_party/jsr-305/src"]
+	path = third_party/jsr-305/src
+	url = https://chromium.googlesource.com/external/jsr-305.git
+	os = android
 [submodule "third_party/leveldatabase/src"]
 	path = third_party/leveldatabase/src
 	url = https://chromium.googlesource.com/external/leveldb.git
 	os = all
+[submodule "third_party/libaddressinput/src"]
+	path = third_party/libaddressinput/src
+	url = https://chromium.googlesource.com/external/libaddressinput.git
+	os = all
+[submodule "third_party/libc++/trunk"]
+	path = third_party/libc++/trunk
+	url = https://llvm.googlesource.com/libcxx.git
+	os = all
+[submodule "third_party/libc++abi/trunk"]
+	path = third_party/libc++abi/trunk
+	url = https://llvm.googlesource.com/libcxxabi.git
+	os = all
 [submodule "third_party/libexif/sources"]
 	path = third_party/libexif/sources
 	url = https://chromium.googlesource.com/chromium/deps/libexif/sources.git
 	os = all
-[submodule "third_party/libjingle/source"]
-	path = third_party/libjingle/source
-	url = https://chromium.googlesource.com/external/libjingle.git
+[submodule "third_party/libjingle/source/talk"]
+	path = third_party/libjingle/source/talk
+	url = https://chromium.googlesource.com/external/webrtc/trunk/talk.git
 	os = all
 [submodule "third_party/libjpeg_turbo"]
 	path = third_party/libjpeg_turbo
 	url = https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git
 	os = all
+[submodule "third_party/liblouis/src"]
+	path = third_party/liblouis/src
+	url = https://chromium.googlesource.com/external/liblouis.git
+	os = unix
 [submodule "third_party/libmtp"]
 	path = third_party/libmtp
 	url = https://chromium.googlesource.com/chromium/deps/libmtp.git
@@ -266,6 +262,10 @@
 	path = third_party/libvpx
 	url = https://chromium.googlesource.com/chromium/deps/libvpx.git
 	os = all
+[submodule "third_party/libwebm/source"]
+	path = third_party/libwebm/source
+	url = https://chromium.googlesource.com/webm/libwebm.git
+	os = all
 [submodule "third_party/libyuv"]
 	path = third_party/libyuv
 	url = https://chromium.googlesource.com/external/libyuv.git
@@ -277,19 +277,15 @@
 [submodule "third_party/lss"]
 	path = third_party/lss
 	url = https://chromium.googlesource.com/external/linux-syscall-support/lss.git
-	os = unix
+	os = android,unix
+[submodule "third_party/mesa/src"]
+	path = third_party/mesa/src
+	url = https://chromium.googlesource.com/chromium/deps/mesa.git
+	os = all
 [submodule "third_party/mingw-w64/mingw/bin"]
 	path = third_party/mingw-w64/mingw/bin
 	url = https://chromium.googlesource.com/native_client/deps/third_party/mingw-w64/mingw/bin.git
 	os = win
-[submodule "third_party/mozc/chrome/chromeos/renderer"]
-	path = third_party/mozc/chrome/chromeos/renderer
-	url = https://chromium.googlesource.com/external/mozc/src/chrome/chromeos/renderer.git
-	os = all
-[submodule "third_party/mozc/session"]
-	path = third_party/mozc/session
-	url = https://chromium.googlesource.com/external/mozc/src/session.git
-	os = all
 [submodule "third_party/mtpd/source"]
 	path = third_party/mtpd/source
 	url = https://chromium.googlesource.com/chromiumos/platform/mtpd.git
@@ -302,10 +298,14 @@
 	path = third_party/nss
 	url = https://chromium.googlesource.com/chromium/deps/nss.git
 	os = win,ios,mac
+[submodule "third_party/openmax_dl"]
+	path = third_party/openmax_dl
+	url = https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git
+	os = all
 [submodule "third_party/openssl"]
 	path = third_party/openssl
 	url = https://chromium.googlesource.com/chromium/deps/openssl.git
-	os = unix
+	os = android,unix
 [submodule "third_party/opus/src"]
 	path = third_party/opus/src
 	url = https://chromium.googlesource.com/chromium/deps/opus.git
@@ -330,22 +330,18 @@
 	path = third_party/psyco_win32
 	url = https://chromium.googlesource.com/chromium/deps/psyco_win32.git
 	os = win
+[submodule "third_party/pyelftools"]
+	path = third_party/pyelftools
+	url = https://chromium.googlesource.com/chromiumos/third_party/pyelftools.git
+	os = unix
 [submodule "third_party/pyftpdlib/src"]
 	path = third_party/pyftpdlib/src
 	url = https://chromium.googlesource.com/external/pyftpdlib.git
 	os = all
-[submodule "third_party/pylib"]
-	path = third_party/pylib
-	url = 
-	os = ios
 [submodule "third_party/pymox/src"]
 	path = third_party/pymox/src
-	url = https://chromium.googlesource.com/external/pymox.git
-	os = all
-[submodule "third_party/python_26"]
-	path = third_party/python_26
-	url = https://chromium.googlesource.com/chromium/deps/python_26.git
-	os = win
+	url = 
+	os = ios
 [submodule "third_party/pywebsocket/src"]
 	path = third_party/pywebsocket/src
 	url = https://chromium.googlesource.com/external/pywebsocket/src.git
@@ -413,35 +409,35 @@
 [submodule "third_party/undoview"]
 	path = third_party/undoview
 	url = https://chromium.googlesource.com/chromium/deps/undoview.git
+	os = unix,ios
+[submodule "third_party/usrsctp/usrsctplib"]
+	path = third_party/usrsctp/usrsctplib
+	url = https://chromium.googlesource.com/external/usrsctplib.git
 	os = all
 [submodule "third_party/v8-i18n"]
 	path = third_party/v8-i18n
-	url = https://chromium.googlesource.com/external/v8-i18n.git
-	os = all
+	url = 
+	os = ios
 [submodule "third_party/webdriver/pylib"]
 	path = third_party/webdriver/pylib
 	url = https://chromium.googlesource.com/external/selenium/py.git
 	os = all
-[submodule "third_party/webgl_conformance"]
-	path = third_party/webgl_conformance
-	url = https://chromium.googlesource.com/chromium/deps/webgl/sdk/tests.git
-	os = all
+[submodule "third_party/webgl"]
+	path = third_party/webgl
+	url = 
+	os = ios
 [submodule "third_party/webpagereplay"]
 	path = third_party/webpagereplay
 	url = https://chromium.googlesource.com/external/web-page-replay.git
 	os = all
 [submodule "third_party/webrtc"]
 	path = third_party/webrtc
-	url = https://chromium.googlesource.com/external/webrtc/stable/src.git
+	url = https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git
 	os = all
 [submodule "third_party/xdg-utils"]
 	path = third_party/xdg-utils
 	url = https://chromium.googlesource.com/chromium/deps/xdg-utils.git
 	os = unix
-[submodule "third_party/xulrunner-sdk"]
-	path = third_party/xulrunner-sdk
-	url = https://chromium.googlesource.com/chromium/deps/xulrunner-sdk.git
-	os = win
 [submodule "third_party/yasm/binaries"]
 	path = third_party/yasm/binaries
 	url = https://chromium.googlesource.com/chromium/deps/yasm/binaries.git
@@ -466,9 +462,9 @@
 	path = tools/page_cycler/acid3
 	url = https://chromium.googlesource.com/chromium/deps/acid3.git
 	os = all
-[submodule "tools/swarm_client"]
-	path = tools/swarm_client
-	url = https://chromium.googlesource.com/chromium/tools/swarm_client.git
+[submodule "tools/swarming_client"]
+	path = tools/swarming_client
+	url = https://chromium.googlesource.com/external/swarming.client.git
 	os = all
 [submodule "v8"]
 	path = v8