diff options
author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-24 07:59:12 +0000 |
---|---|---|
committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-24 07:59:12 +0000 |
commit | 4dba950406ec24485d2a79a666f70859a7f0ab75 (patch) | |
tree | 17d30397fd6ebec8ade80f11e9d4c893b9bfc608 | |
parent | b84d62f9d437e605ba0694cd9d888354fd6e025b (diff) | |
download | chromium_src-4dba950406ec24485d2a79a666f70859a7f0ab75.zip chromium_src-4dba950406ec24485d2a79a666f70859a7f0ab75.tar.gz chromium_src-4dba950406ec24485d2a79a666f70859a7f0ab75.tar.bz2 |
Fix memory leaks in BufferedDataSource, BufferedResourceLoader and SimpleDataSource unit tests.
BUG=65664
TEST=test_shell_tests + valgrind/heapcheck
Review URL: http://codereview.chromium.org/6246017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72316 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | tools/heapcheck/suppressions.txt | 24 | ||||
-rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 29 | ||||
-rw-r--r-- | webkit/glue/media/buffered_data_source_unittest.cc | 1 | ||||
-rw-r--r-- | webkit/glue/media/buffered_resource_loader_unittest.cc | 2 | ||||
-rw-r--r-- | webkit/glue/media/simple_data_source_unittest.cc | 1 |
5 files changed, 0 insertions, 57 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 70ae9d8..c31497f 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1073,30 +1073,6 @@ fun:testing::Test::Run } { - bug_65664a - Heapcheck:Leak - fun:webkit_glue::BufferedResourceLoaderTest::Initialize - fun:webkit_glue::BufferedResourceLoaderTest* -} -{ - bug_65664b - Heapcheck:Leak - fun:webkit_glue::BufferedDataSourceTest::InitializeDataSource - fun:webkit_glue::BufferedDataSourceTest* -} -{ - bug_65664c - Heapcheck:Leak - fun:webkit_glue::SimpleDataSourceTest::InitializeDataSource - fun:webkit_glue::SimpleDataSourceTest* -} -{ - bug_65664d - Heapcheck:Leak - fun:webkit_glue::SimpleDataSourceTest_InitializeData_Test::TestBody - fun:testing::HandleExceptionsInMethodIfSupported -} -{ bug_65680a Heapcheck:Leak fun:remoting::ScreenRecorderTest_OneRecordCycle_Test::TestBody diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 27c308f..026c4d7d 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3371,34 +3371,6 @@ fun:_ZN13ResourcesUtil18GetThemeResourceIdERKSs } { - bug_65664a - Memcheck:Leak - fun:_Znw* - fun:_ZN11webkit_glue26BufferedResourceLoaderTest10InitializeEPKcii - fun:_ZN11webkit_glue*BufferedResourceLoaderTest* -} -{ - bug_65664b - Memcheck:Leak - fun:_Znw* - fun:_ZN11webkit_glue22BufferedDataSourceTest20InitializeDataSource* - fun:_ZN11webkit_glue*BufferedDataSourceTest* -} -{ - bug_65664c - Memcheck:Leak - fun:_Znw* - fun:_ZN11webkit_glue20SimpleDataSourceTest20InitializeDataSourceEPKcPN5media12MockCallbackE - fun:_ZN11webkit_glue*SimpleDataSourceTest* -} -{ - bug_65664d - Memcheck:Leak - fun:_Znw* - fun:_ZN11webkit_glue40SimpleDataSourceTest_InitializeData_Test8TestBodyEv - fun:_ZN7testing*HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc -} -{ bug_65680a Memcheck:Leak fun:_Znw* @@ -3653,4 +3625,3 @@ fun:_ZN9talk_base12MessageQueue8DispatchEPNS_7MessageE fun:_ZN9talk_base6Thread15ProcessMessagesEi } -
\ No newline at end of file diff --git a/webkit/glue/media/buffered_data_source_unittest.cc b/webkit/glue/media/buffered_data_source_unittest.cc index 8d55b4d..6e9a87d 100644 --- a/webkit/glue/media/buffered_data_source_unittest.cc +++ b/webkit/glue/media/buffered_data_source_unittest.cc @@ -105,7 +105,6 @@ class BufferedDataSourceTest : public testing::Test { } virtual ~BufferedDataSourceTest() { - ignore_result(frame_.release()); } void ExpectCreateAndStartResourceLoader(int start_error) { diff --git a/webkit/glue/media/buffered_resource_loader_unittest.cc b/webkit/glue/media/buffered_resource_loader_unittest.cc index fc8851c..4ba8a27 100644 --- a/webkit/glue/media/buffered_resource_loader_unittest.cc +++ b/webkit/glue/media/buffered_resource_loader_unittest.cc @@ -74,7 +74,6 @@ class BufferedResourceLoaderTest : public testing::Test { } virtual ~BufferedResourceLoaderTest() { - ignore_result(frame_.release()); } void Initialize(const char* url, int first_position, int last_position) { @@ -483,4 +482,3 @@ TEST_F(BufferedResourceLoaderTest, AllowDefer_DeferredReadPastWindow) { // TODO(hclam): add unit test for defer loading. } // namespace webkit_glue - diff --git a/webkit/glue/media/simple_data_source_unittest.cc b/webkit/glue/media/simple_data_source_unittest.cc index 03346bd..48131b1 100644 --- a/webkit/glue/media/simple_data_source_unittest.cc +++ b/webkit/glue/media/simple_data_source_unittest.cc @@ -56,7 +56,6 @@ class SimpleDataSourceTest : public testing::Test { } virtual ~SimpleDataSourceTest() { - ignore_result(frame_.release()); } void InitializeDataSource(const char* url, |